KUBESAW-187: Have a unique label for our operators #597
Conversation
Signed-off-by: Feny Mehta <[email protected]>
fbm3307
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
config/manager/manager.yaml
Outdated
| control-plane: controller-manager | ||
| control-plane: kubesaw-controller-manager |
There was a problem hiding this comment.
TBH, I'm not sure if this labels is not used somewhere else (eg in sanbox-sre). Let's keep the label there and add a new one instead
There was a problem hiding this comment.
yes you are right, added new ones now.
Signed-off-by: Feny Mehta <[email protected]>
|
fbm3307
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, MatousJobanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #597 +/- ##
=======================================
Coverage 83.56% 83.56%
=======================================
Files 28 28
Lines 2604 2604
=======================================
Hits 2176 2176
Misses 288 288
Partials 140 140 |
openshift-merge-bot
bot
merged commit f80135a
into
codeready-toolchain:master
This reverts commit f80135a.
Have a unique label instead of default controller-manger, so that it becomes easier to perform operations to only our operators
this is a predecessor for PR
KSCTL - kubesaw/ksctl#79
Similar PR
Host-Operator - codeready-toolchain/host-operator#1087