Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive the updates from the API repo for the new fields in the ToolchainCluster status #1056

Merged
merged 6 commits into from
Jul 8, 2024

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Jul 4, 2024

This trivially just updates the API and gets the updated CRD definitions.

Associated PRs:

@metlos
Copy link
Contributor Author

metlos commented Jul 5, 2024

/retest

Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would separate update of the api from the changes in CRD to make the PR merges more fluent

go.mod Outdated
Comment on lines 131 to 132

replace github.com/codeready-toolchain/api => github.com/metlos/api v0.0.0-20240708084953-3d53a2121f9f
Copy link
Contributor

@MatousJobanek MatousJobanek Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should update the dependency as a separate PR - together with the changes in the code; otherwise, you merge api PR and then you would need to wait for another round of e2e tests.
So ideally, in such cases when we introduce only a new fields so it stays backward compatible with the logic in the code, the PR would contain only the result of the make generate command, nothing else.

Copy link

openshift-ci bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MatousJobanek, metlos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.92%. Comparing base (655a1f9) to head (398db97).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1056      +/-   ##
==========================================
+ Coverage   84.88%   84.92%   +0.03%     
==========================================
  Files          55       55              
  Lines        5015     5015              
==========================================
+ Hits         4257     4259       +2     
+ Misses        585      583       -2     
  Partials      173      173              

see 2 files with indirect coverage changes

@metlos metlos merged commit 3186661 into codeready-toolchain:master Jul 8, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants