-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Receive the updates from the API repo for the new fields in the ToolchainCluster status #1056
Receive the updates from the API repo for the new fields in the ToolchainCluster status #1056
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would separate update of the api from the changes in CRD to make the PR merges more fluent
go.mod
Outdated
|
||
replace github.com/codeready-toolchain/api => github.com/metlos/api v0.0.0-20240708084953-3d53a2121f9f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should update the dependency as a separate PR - together with the changes in the code; otherwise, you merge api PR and then you would need to wait for another round of e2e tests.
So ideally, in such cases when we introduce only a new fields so it stays backward compatible with the logic in the code, the PR would contain only the result of the make generate
command, nothing else.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MatousJobanek, metlos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1056 +/- ##
==========================================
+ Coverage 84.88% 84.92% +0.03%
==========================================
Files 55 55
Lines 5015 5015
==========================================
+ Hits 4257 4259 +2
+ Misses 585 583 -2
Partials 173 173 |
This trivially just updates the API and gets the updated CRD definitions.
Associated PRs: