Move info into tc status #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the changes after we migrate to kubeconfig-based connections. Add fields to the ToolchainCluster.Status that will advertise info from kubeconfig.
metlos
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
This was referenced Jul 4, 2024
mfrancisc
reviewed
Jul 4, 2024
Co-authored-by: Francisc Munteanu <[email protected]>
mfrancisc
approved these changes
Jul 4, 2024
MatousJobanek
approved these changes
Jul 8, 2024
MatousJobanek
approved these changes
Jul 8, 2024
| @@ -34,20 +34,33 @@ const ( | |||
| type ToolchainClusterSpec struct { | |||
| // The API endpoint of the member cluster. This can be a hostname, | |||
| // hostname:port, IP or IP:port. | |||
| // | |||
| // Be aware that this field is going to be replaced with | |||
| // the Status.APIEndpoint in the future. | |||
| APIEndpoint string `json:"apiEndpoint"` | |||
There was a problem hiding this comment.
btw, you could have made this field optional as well, so you can drop populating it before you remove it from the API
There was a problem hiding this comment.
Not sure what's better from the client's POV. A hard error from using a removed field or a soft error caused by empty values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces new fields into the ToolchainCluster status:
apiEndpointandoperatorNamespaceare introduced into the status because these fields will be read from the kubeconfig contained in the ToolchainCluster secret instead of explicitly being set in the ToolchainCluster's spec.Checks
Did you run
make generatetarget? yesDid
make generatechange anything in other projects (host-operator, member-operator)? yesIn case of new CRD, did you the following? no new CRD
In case other projects are changed, please provides PR links.