-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature annotation key prefix #431
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package v1alpha1 | ||
|
||
const ( | ||
// FeatureToggleNameAnnotationKey is used for referring tier template objects to feature toggles defined in configuration | ||
FeatureToggleNameAnnotationKey = LabelKeyPrefix + "feature" | ||
|
||
// FeatureAnnotationKeyPrefix is used in feature annotation keys in Space, NSTemplate and other resources | ||
// to refer to the corresponding feature toggle from the configuration: | ||
// "toolchain.dev.openshift.com/feature/<feature-name> | ||
FeatureAnnotationKeyPrefix = FeatureToggleNameAnnotationKey + "/" | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another option would be to list the enabled features in the value of the annotation:
That would be easy to manage too, right? Or is there any specific reason for putting the key into the key part?
I mean, it would be understandable if we wanted to store it as a label and list them, but that's not the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I misunderstanding this or there can be only one slash in the annotation key according to https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/#syntax-and-character-set ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mfrancisc you are right. It doesn't actually allow more than one slash in the annotation key. It's not actually clear from the documentation but I tried it and it failed the validation.
@MatousJobanek I was thinking about using a list of features in a single annotation instead of separate annotations for each feature but thought that it would be a bit simpler to handle multiple annotations. But since multiple slashes are not allowed anyway I'm going to switch to a single annotation now.