Add feature annotation key prefix

[alexeykazakov]

Description

A few sentences describing the overall goals of the pull request's commits.

Checks

1. Did you run make generate target? yes

2. Did make generate change anything in other projects (host-operator, member-operator)? no

[MatousJobanek]

another option would be to list the enabled features in the value of the annotation:

Suggested change

	FeatureAnnotationKeyPrefix = FeatureToggleNameAnnotationKey + "/"
	toolchain.dev.openshift.com/features: o-lightspeed,another-one,...

That would be easy to manage too, right? Or is there any specific reason for putting the key into the key part?
I mean, it would be understandable if we wanted to store it as a label and list them, but that's not the case.

[mfrancisc]

Am I misunderstanding this or there can be only one slash in the annotation key according to https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/#syntax-and-character-set ?

[alexeykazakov]

@mfrancisc you are right. It doesn't actually allow more than one slash in the annotation key. It's not actually clear from the documentation but I tried it and it failed the validation.

@MatousJobanek I was thinking about using a list of features in a single annotation instead of separate annotations for each feature but thought that it would be a bit simpler to handle multiple annotations. But since multiple slashes are not allowed anyway I'm going to switch to a single annotation now.

[alexeykazakov]

No needed anymore. Closing.