nogo: fix unconvert exclude rules #130993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
srosenberg
requested review from
a team,
nameisbhaskar and
vidit-bhat
and removed request for
a team
In [1], a regression was added in `exclude_files` for the `unconvert` linter. This regression only affects builds instrumented with coverage; see [2] for further details. As a workaround for [2], we extend `exclude_files` to exclude Go sources generated from protobuf, having the optional suffix of the form `_[0-9]+`. [1] cockroachdb#124155 [2] bazel-contrib/rules_go#4110 Epic: none Release note: None
srosenberg
force-pushed
the
sr/nogo_fix_unconvert_exclusion
branch
from
24205ee
to
70d0f8c
Compare
|
The following now builds, |
vidit-bhat
approved these changes
Oct 4, 2024
|
TFTR! bors r=vidit-bhat,nameisbhaskar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In [1], a regression was added in
exclude_filesfor the
unconvertlinter. This regression onlyaffects builds instrumented with coverage; see [2] for further details.
As a workaround for [2], we extend
exclude_filesto exclude Go sources generated from protobuf,having the optional suffix of the form
_[0-9]+.[1] #124155
[2] bazel-contrib/rules_go#4110
Epic: none
Release note: None