Skip to content

Commit

Permalink
Merge #130993
Browse files Browse the repository at this point in the history
130993: nogo: fix unconvert exclude rules r=vidit-bhat,nameisbhaskar a=srosenberg

In [1], a regression was added in `exclude_files`
for the `unconvert` linter. This regression only
affects builds instrumented with coverage; see [2] for further details.

As a workaround for [2], we extend `exclude_files` to exclude Go sources generated from protobuf,
having the optional suffix of the form `_[0-9]+`.

[1] #124155
[2] bazel-contrib/rules_go#4110

Epic: none

Release note: None

Co-authored-by: Stan Rosenberg <[email protected]>
  • Loading branch information
craig[bot] and srosenberg committed Oct 25, 2024
2 parents 98884f4 + 70d0f8c commit 163ee9a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build/bazelutil/nogo_config.json
Original file line number Diff line number Diff line change
Expand Up @@ -1624,7 +1624,7 @@
"github.com/elastic/gosigar": "third-party",
"github.com/shirou/gopsutil": "third-party code",
"pkg/.*\\.eg\\.go$": "generated code",
".*\\.pb\\.go$": "generated code",
".*\\.pb(_[0-9]+)?\\.go$": "generated code",
".*\\.pb\\.gw\\.go$": "generated code",
"pkg/.*_generated\\.go$": "generated code"
}
Expand Down

0 comments on commit 163ee9a

Please sign in to comment.