Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containers/ws: Install our other Cockpit pages #21117

Merged
merged 3 commits into from
Oct 15, 2024
Merged

containers/ws: Install our other Cockpit pages #21117

merged 3 commits into from
Oct 15, 2024

Commits on Oct 14, 2024

  1. apps: Hide page if PackageKit is not installed. 

    The Applications page uses PackageKit. Hide it via a manifest condition
if it isn't available. Similar to commit 0278284 for the Software
Updates page.
    @martinpitt
    martinpitt committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    c52caa7 View commit details
    Browse the repository at this point in the history

  2. apps: Hide page in beiboot mode 

    Installing more apps only makes sense in the classic "installed cockpit
packages" world. But we don't want it in a beiboot session, as
installing any cockpit-* extension would install cockpit-bridge as a
dependency, and that then completely changes the session experience --
up to the point that we don't even install cockpit-system for the
Overview.

Since we dropped the cockpit-pcp on-demand install from the metrics
page, this was the last page that installed cockpit-* packages. This
is a prerequisite for enabling beiboot mode for distro packages
(although not sufficient yet), and adding more packages to the
cockpit/ws container.

This cannot currently be integration-tested: We don't yet support
beibooting for the rpms/debs, and Fedora CoreOS + ws container doesn't
have PackageKit.
    @martinpitt
    martinpitt committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    cf0624c View commit details
    Browse the repository at this point in the history

  3. containers/ws: Install our other Cockpit pages 

    Kdump, Networking, SELinux, Storaged, and Software Updates are all fine
and useful for beiboot mode. Apps doesn't, but that's hidden by the
manifest condition.
    @martinpitt
    martinpitt committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    cb2e05e View commit details
    Browse the repository at this point in the history