containers/ws: Install our other Cockpit pages #21117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Applications page uses PackageKit. Hide it via a manifest condition if it isn't available. Similar to commit 0278284 for the Software Updates page.
Installing more apps only makes sense in the classic "installed cockpit packages" world. But we don't want it in a beiboot session, as installing any cockpit-* extension would install cockpit-bridge as a dependency, and that then completely changes the session experience -- up to the point that we don't even install cockpit-system for the Overview. Since we dropped the cockpit-pcp on-demand install from the metrics page, this was the last page that installed cockpit-* packages. This is a prerequisite for enabling beiboot mode for distro packages (although not sufficient yet), and adding more packages to the cockpit/ws container. This cannot currently be integration-tested: We don't yet support beibooting for the rpms/debs, and Fedora CoreOS + ws container doesn't have PackageKit.
Kdump, Networking, SELinux, Storaged, and Software Updates are all fine and useful for beiboot mode. Apps doesn't, but that's hidden by the manifest condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kdump, Networking, SELinux, Storaged, and Software Updates are all fine
and useful for beiboot mode. Apps doesn't, but that's hidden by the
manifest condition.
Plus two fixes for the Applications page.
Aside from boosting the ws container, this is also a prerequisite for https://issues.redhat.com/browse/COCKPIT-1178.