-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sosreport: Add fallback error message, fix testInsightsClient failure on rhel4edge #19104
Conversation
rhel-8-9 does not seem to pick up the mock /usr/local/bin/sos. That's because sos lives in /usr/sbin, and it has a different Fixed both. |
ah nice, thanks! My first thought when I checked screenshots in the naughty was, why is there no error in the dialog |
This failure looks unrelated, but repeats ND@6 did not run any SOS related test. Retrying to compare. I ran the test locally by itself four times, and they all passed. I also ran the exact same list of ND@6 tests locally:
These also passed. But on CI it failed again. I added two commits which may help. It also happens on other PRs, so this is unrelated. It may have come with cockpit-project/bots#5015 (yesterday's image refresh), but the test succeeded there. This debug log shows that there are no insights related processes, and This log brings some insights (haha):
I can't find the source of this anywhere. So one more round.. This reproduces reliably on a CI machine. I don't yet know what the difference is between that and local tasks toolbox. |
889c49b
to
a6f71dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just one comment but not a good reason to block this :)
If `sos report` fails, we can get an empty message in `error`. That will lead to not showing the error in the dialog at all (as it's falsy), even if errorDetail was set. Fix that by adding a generic fallback title. Also log the full error for easier debugging.
stdout gets captured by Machine.execute(). Write the fuser output to stderr so that we can actually see it. Also cover the directory itself, not just its contents.
Our directory watches keep /etc/insights-client busy, so that it cannot be unmounted during cleanup. Explicitly log out to prevent that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Danke!
If
sos report
fails, we can get an empty message inerror
. That will lead to not showing the error in the dialog at all (as it's falsy), even if errorDetail was set. Fix that by adding a generic fallback title.Also log the full error for easier debugging.
I noticed this while investigating the current sos rawhide failure. This looks really unfriendly -- you click "Report", the dialog flickers and nothing happens. Now it shows the error properly: