sosreport: Add fallback error message

If `sos report` fails, we can get an empty message in `error`. That will
lead to not showing the error in the dialog at all (as it's falsy), even
if errorDetail was set. Fix that by adding a generic fallback title.

Also log the full error for easier debugging.

pkg/sosreport/sosreport.jsx

@@ -177,7 +177,8 @@ function sosCreate(args, setProgress, setError, setErrorDetail) {
     });
 
     task.catch(error => {
-        setError(error.toString());
+        console.error(JSON.stringify(error));
+        setError(error.toString() || _("sos report failed"));
         setErrorDetail(output);
     });
 

test/verify/check-sosreport

@@ -107,6 +107,18 @@ only-plugins=release,date,host,cgroups,networking
         b.click("#sos-remove-dialog button:contains(Delete)")
         testlib.wait(lambda: m.execute(f"! test -f /var/tmp/{base_report_gpg} && echo yes"))
 
+        # error reporting
+        self.write_file("/usr/local/bin/sos", """#!/bin/sh
+echo "EssOhEss is kaputt" >&2
+exit 1""", perm="755")
+        b.click("button:contains('Run report')")
+        b.wait_visible("#sos-dialog")
+        b.click("#sos-dialog button:contains(Run report)")
+        b.wait_in_text("#sos-dialog .pf-v5-c-alert", "sos report failed")
+        b.wait_in_text("#sos-dialog .pf-v5-c-alert", "EssOhEss is kaputt")
+        b.click("#sos-dialog button:contains(Cancel)")
+        b.wait_not_present("#sos-dialog")
+
         self.allow_journal_messages('.*comm="sosreport".*')
 
     def testWithUrlRoot(self):