Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build.js: drop ip.js hack #1805

Merged
merged 1 commit into from
Sep 6, 2024
Merged

build.js: drop ip.js hack #1805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import os from 'node:os';
import process from 'node:process';

import copy from 'esbuild-plugin-copy';
import { replace } from 'esbuild-plugin-replace';

import { cockpitCompressPlugin } from './pkg/lib/esbuild-compress-plugin.js';
import { cockpitPoEsbuildPlugin } from './pkg/lib/cockpit-po-plugin.js';
Expand Down Expand Up @@ -101,15 +100,6 @@ const context = await esbuild.context({
{ from: ['./src/index.html'], to: ['./index.html'] },
]
}),
// TODO: The following HACKS are needed for ip module - replace this module with one better maintained
// The replacement is done as ip module imports `os` which is not in our dependencies, but since we don't use
// the functions using the `os` module, we can just replace it with an empty object
replace({
include: /ip.js/,
values: {
"var os": 'var os = {}; // HACK: os is not really used in our used functions from ip.js',
}
}),
...esbuildStylesPlugins,
cockpitPoEsbuildPlugin(),

Expand Down