Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.js: drop ip.js hack #1805

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

jelly
Copy link
Member

@jelly jelly commented Sep 5, 2024

Since f27fc31 we ported from the ip module to the ipaddr.js module. ip was a pure node.js module so required a hack to work.

@jelly jelly requested a review from mvollmer September 5, 2024 10:54
Since f27fc31 we ported from the ip
module to the ipaddr.js module. ip was a pure node.js module so required
a hack to work.
Copy link
Member

@mvollmer mvollmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@mvollmer mvollmer merged commit 0b45bb4 into cockpit-project:main Sep 6, 2024
27 checks passed
@jelly jelly deleted the drop-old-ip-addr-hack branch September 6, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants