test: Use wait_text to check an empty string #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and it fails |
So the test was really useless |
Using wait_in_text(selector, "") always validates as true (since empty string is always subset of any string), rendering the test useless.
skobyda
force-pushed
the
emptyStringTest
branch
from
1e7e51a
to
ee92f76
Compare
martinpitt
requested changes
Sep 5, 2023
| @@ -235,6 +235,19 @@ def run_admin(self, cmd, connectionName='system'): | |||
| else: | |||
| return m.execute(cmd) | |||
|
|
|||
| def deleteDisk(self, target, vm_name="subVmTest1"): | |||
There was a problem hiding this comment.
You just defined this function without using this anywhere. Forgot to commit something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using wait_in_text(selector, "") always validates as true (since empty string is always subset of any string), rendering the test useless.