-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Use wait_text to check an empty string #1195
Conversation
... and it fails |
So the test was really useless |
Using wait_in_text(selector, "") always validates as true (since empty string is always subset of any string), rendering the test useless.
1e7e51a
to
ee92f76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the test properly!
@@ -235,6 +235,19 @@ def run_admin(self, cmd, connectionName='system'): | |||
else: | |||
return m.execute(cmd) | |||
|
|||
def deleteDisk(self, target, vm_name="subVmTest1"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You just defined this function without using this anywhere. Forgot to commit something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Using wait_in_text(selector, "") always validates as true (since empty string is always subset of any string), rendering the test useless.