Skip to content

Commit

Permalink
test: Use wait_text to check an empty string
Browse files Browse the repository at this point in the history
Using wait_in_text(selector, "") always validates as true (since empty
string is always subset of any string), rendering the test useless.
  • Loading branch information
skobyda committed Sep 4, 2023
1 parent aa77497 commit 1e7e51a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/check-machines-storage-pools
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ class TestMachinesStoragePools(VirtualMachinesCase):
b.wait_in_text(f"#pool-myPoolTwo-{connectionName}-volume-VolumeOne-usedby", "subVmTest1")

m.execute("virsh detach-disk --config --target vdc subVmTest1")
b.wait_in_text(f"#pool-myPoolTwo-{connectionName}-volume-VolumeOne-usedby", "")
b.wait_text(f"#pool-myPoolTwo-{connectionName}-volume-VolumeOne-usedby", "")

# Transient pool
self.togglePoolRow("myPoolThree", connectionName)
Expand Down

0 comments on commit 1e7e51a

Please sign in to comment.