-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename test package to parser_test #149
Conversation
This change renames the package for parser tests to parser_test to further limit the dependencies that are required by downstream consumers. Signed-off-by: Evan Lezar <[email protected]>
a0469cd
to
6c29d85
Compare
@elezar Did you test if it actually works? I thought that |
I didn't have a chance to test this yet. I will do so and report back. |
LGTM. I think whenever possible/reasonable (IOW, unless there is a lot of complex unexported code that warrants dedicated unit testing), it is a good idea to put tests into it's own package namespace. This happens automatically if/when ginkgo/gomega is used. |
Is that so? Nothing prevents someone from writing a |
I've always |
LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change renames the package for parser tests to parser_test to further limit the dependencies that are required by downstream consumers.
See the discussion here: kubernetes-sigs/kind#3290 (comment)