Skip to content

Commit

Permalink
Rename test package to parser_test
Browse files Browse the repository at this point in the history
This change renames the package for parser tests to
parser_test to further limit the dependencies that are
required by downstream consumers.

Signed-off-by: Evan Lezar <[email protected]>
  • Loading branch information
elezar committed Aug 4, 2023
1 parent d48612f commit 6c29d85
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions pkg/parser/parser_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,13 @@
limitations under the License.
*/

package parser
package parser_test

import (
"testing"

"github.com/container-orchestrated-devices/container-device-interface/pkg/parser"

"github.com/stretchr/testify/require"
)

Expand Down Expand Up @@ -126,24 +128,24 @@ func TestQualifiedName(t *testing.T) {
},
} {
t.Run(tc.name, func(t *testing.T) {
vendor, class, name, err := ParseQualifiedName(tc.device)
vendor, class, name, err := parser.ParseQualifiedName(tc.device)
if tc.isQualified {
require.True(t, IsQualifiedName(tc.device), "qualified name %q", tc.device)
require.True(t, parser.IsQualifiedName(tc.device), "qualified name %q", tc.device)
require.NoError(t, err)
require.Equal(t, tc.vendor, vendor, "qualified name %q", tc.device)
require.Equal(t, tc.class, class, "qualified name %q", tc.device)
require.Equal(t, tc.name, name, "qualified name %q", tc.device)

vendor, class, name = ParseDevice(tc.device)
vendor, class, name = parser.ParseDevice(tc.device)
require.Equal(t, tc.vendor, vendor, "parsed name %q", tc.device)
require.Equal(t, tc.class, class, "parse name %q", tc.device)
require.Equal(t, tc.name, name, "parsed name %q", tc.device)

device := QualifiedName(vendor, class, name)
device := parser.QualifiedName(vendor, class, name)
require.Equal(t, tc.device, device, "constructed device %q", tc.device)
} else if tc.isParsable {
require.False(t, IsQualifiedName(tc.device), "parsed name %q", tc.device)
vendor, class, name = ParseDevice(tc.device)
require.False(t, parser.IsQualifiedName(tc.device), "parsed name %q", tc.device)
vendor, class, name = parser.ParseDevice(tc.device)
require.Equal(t, tc.vendor, vendor, "parsed name %q", tc.device)
require.Equal(t, tc.class, class, "parse name %q", tc.device)
require.Equal(t, tc.name, name, "parsed name %q", tc.device)
Expand Down

0 comments on commit 6c29d85

Please sign in to comment.