Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cole/capture span fields #5

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Cole/capture span fields #5

merged 2 commits into from
Oct 9, 2023

Commits on Oct 8, 2023

  1. fix: try to capture span fields

    @cmackenzie1
    cmackenzie1 committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    996ef03 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. refactor: add visitor pattern for tracing fields 

    By adding a visitor pattern, we can further customize the output of
each event. For example, the `message` field was never actually
being formatted with the provided `message_name` field.

Also, this fixes an issue where the number of nested spans exceeds
one. Fields from any previous spans were being ignored and not formatted
in the final output.
    @cmackenzie1
    cmackenzie1 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    719405d View commit details
    Browse the repository at this point in the history