Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cole/capture span fields #5

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Cole/capture span fields #5

merged 2 commits into from
Oct 9, 2023

Conversation

cmackenzie1
Copy link
Owner

No description provided.

By adding a visitor pattern, we can further customize the output of
each event. For example, the `message` field was never actually
being formatted with the provided `message_name` field.

Also, this fixes an issue where the number of nested spans exceeds
one. Fields from any previous spans were being ignored and not formatted
in the final output.
@cmackenzie1 cmackenzie1 merged commit ae8b401 into main Oct 9, 2023
1 check passed
@cmackenzie1 cmackenzie1 deleted the cole/capture-span-fields branch October 9, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant