fix: Aligns drawers slider to split panel and matches side nav animation

[katiegeorge]

Description

The slider of drawers didn't line up vertically with the slider of split panel.

Before:

After:

Also, the drawer was animated both in and out, which didn't match the navigation on the other side. This removes the animation out so that the two match. There is a separate issue with the animation that creates lag in certain scenarios, but since that is a more complex fix, this is a holdover for the launch of drawers until that bug can be fixed.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

• Changes include appropriate documentation updates.
• Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
• Changes do not include unsupported browser features, see CONTRIBUTING.md.
• Changes were manually tested for accessibility, see accessibility guidelines.

Security

• If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

• Changes are covered with new/existing unit tests?
• Changes are covered with new/existing integration tests?

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (abdd30c) 94.04% compared to head (beb5857) 94.05%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1587      +/-   ##
==========================================
+ Coverage   94.04%   94.05%   +0.01%     
==========================================
  Files         649      649              
  Lines       17565    17565              
  Branches     5767     5767              
==========================================
+ Hits        16519    16521       +2     
+ Misses        977      975       -2     
  Partials       69       69              

Files	Coverage Δ
src/app-layout/visual-refresh/drawers.tsx	94.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rubencarvalho]

Do we have a visual regression test that could cover this? :)

[rubencarvalho]

I left a couple of non-blocking comments 👍

[rubencarvalho]

nit: I'm not sure if the number of rows might change, but we could be a bit more defensive here.

Suggested change

	grid-row: 1 / span 3;
	grid-row: 1 / -1;

[katiegeorge]

This is a great solution! There are a couple other places in this file that use the span method, so they should all be consistent. I think this works for now, since the rows won't change.

[katiegeorge]

Do we have a visual regression test that could cover this? :)

We currently have screenshot tests for an open drawer, but not one with an open drawer and open split panel. I'll make a note to add one as a follow up, since we may be updating them for the launch.