Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adds split panel url params #1593

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: Adds split panel url params #1593

merged 1 commit into from
Sep 27, 2023

Conversation

katiegeorge
Copy link
Member

Description

Adds Split Panel url params so that we can add a screenshot test with an open split panel and open drawers.
See #1587 for additional context.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6dbdef1) 94.05% compared to head (f9a14a4) 94.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1593   +/-   ##
=======================================
  Coverage   94.05%   94.05%           
=======================================
  Files         649      649           
  Lines       17572    17572           
  Branches     5770     5770           
=======================================
  Hits        16528    16528           
  Misses        975      975           
  Partials       69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katiegeorge katiegeorge merged commit b7d291c into main Sep 27, 2023
31 checks passed
@katiegeorge katiegeorge deleted the kg/split-panel-params branch September 27, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants