generate: don't output default ruleset ref values
#596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbednarz
force-pushed
the
dont-output-default-refs
branch
from
5c894cd
to
053b928
Compare
Updates the output generation to skip outputting the `ref` value in the case where it is the computed default (same as `id`). This aligns the output with the expectation in the schema[1] where the `ref` maybe computed. [1]: cloudflare/terraform-provider-cloudflare@5b01f8d Signed-off-by: Jacob Bednarz <[email protected]>
jacobbednarz
force-pushed
the
dont-output-default-refs
branch
from
053b928
to
105fcf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the output generation to skip outputting the
refvalue in the case where it is the computed default (same asid).This aligns the output with the expectation in the schema where the
refmaybe computed.