generate: don't output default ruleset ref values

Updates the output generation to skip outputting the `ref` value in the case where it is the computed default (same as `id`). This aligns the output with the expectation in the schema[1] where the `ref` maybe computed. [1]: cloudflare/terraform-provider-cloudflare@5b01f8d Signed-off-by: Jacob Bednarz <[email protected]>
cloudflare · Aug 11, 2023 · 5c894cd · 5c894cd
1 parent 17e43c0
commit 5c894cd
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/internal/app/cf-terraforming/cmd/generate.go b/internal/app/cf-terraforming/cmd/generate.go
@@ -791,6 +791,14 @@ func generateResources() func(cmd *cobra.Command, args []string) {
 				rules := jsonStructData[i].(map[string]interface{})["rules"]
 				if rules != nil {
 					for ruleCounter := range rules.([]interface{}) {
+						// should the `ref` be the default `id`, don't output it
+						// as we don't need to track a computed default.
+						id := rules.([]interface{})[ruleCounter].(map[string]interface{})["id"]
+						ref := rules.([]interface{})[ruleCounter].(map[string]interface{})["ref"]
+						if id == ref {
+							rules.([]interface{})[ruleCounter].(map[string]interface{})["ref"] = nil
+						}
+
 						actionParams := rules.([]interface{})[ruleCounter].(map[string]interface{})["action_parameters"]
 						if actionParams != nil {
 							// check for log custom fields that need to be transformed