-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PERFSCALE-2454]: Publish multi-arch container images #34
Merged
Merged
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c212114
Publish multi-arch container images
krishvoor 8fc7a95
Merge branch 'cloud-bulldozer:main' into updates_to_gha
krishvoor d8f2a13
Updates the build_system via podman
krishvoor dd1d241
Containerfile updates
krishvoor ebd4b22
Updates to the following:
krishvoor e7cfc06
Updates to the GHA workflows
krishvoor 0c846b8
Minor nit
krishvoor 9f9c2e2
Updates the secrets variable
krishvoor 21adbdc
Updates to the build-container.yml
krishvoor 8e22250
Update the GO_VER
krishvoor b54da04
Switch to push request
krishvoor a4a800a
Merge branch 'main' into updates_to_gha
rsevilla87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
name: Release ingress-netperf container image | ||
|
||
on: | ||
pull_request: | ||
paths: | ||
- 'containers/**' # Trigger only when Dockerfile changes in a pull request | ||
|
||
env: | ||
CONTAINER_REGISTRY: ${{ github.repository_owner == 'cloud-bulldozer' && 'quay.io' }} | ||
GO_VER: 1.19 | ||
|
||
jobs: | ||
|
||
build-and-push-container-images: | ||
name: Build and Push Container Images | ||
runs-on: ubuntu-latest | ||
|
||
permissions: | ||
contents: read | ||
packages: write | ||
|
||
steps: | ||
- name: Setup QEMU | ||
uses: docker/setup-qemu-action@v2 | ||
|
||
- name: Setup docker-buildx | ||
uses: docker/setup-buildx-action@v2 | ||
with: | ||
buildkitd-flags: --debug | ||
config-inline: | | ||
[worker.oci] | ||
max-parallelism = 1 | ||
krishvoor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
|
||
- name: Login to the ${{ env.CONTAINER_REGISTRY }} Container Registry | ||
uses: docker/login-action@v2 | ||
with: | ||
registry: ${{ env.CONTAINER_REGISTRY }} | ||
username: ${{ env.CONTAINER_REGISTRY == 'quay.io' && secrets.QUAY_USER || github.actor }} | ||
password: ${{ env.CONTAINER_REGISTRY == 'quay.io' && secrets.QUAY_TOKEN || secrets.GITHUB_TOKEN } | ||
|
||
- name: Docker meta | ||
id: meta | ||
uses: docker/metadata-action@v4 | ||
with: | ||
images: ${{ env.CONTAINER_REGISTRY }}/${{ github.repository_owner }}/netperf | ||
tags: | | ||
type=semver,pattern={{version}} | ||
type=semver,pattern={{major}}.{{minor}} | ||
type=semver,pattern={{major}}.{{minor}}.{{patch}} | ||
krishvoor marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- name: Build and Push Multi archiecture Image | ||
id: push | ||
run: | | ||
make gha-build | ||
make push | ||
env: | ||
GO_VER=${{ env.GO_VER }} | ||
GO_TAGS= |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We must trigger this workflow on a push event. Doing it on a
pull_request
event is dangerous, as any PR would trigger a container build and can introduce incorrect or malicious code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, will change from
pull_request