-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PERFSCALE-2454]: Publish multi-arch container images #34
Conversation
This PR introduces multi-arch build/publish approach Signed-off-by: Krishna Harsha Voora <[email protected]>
1) make gha-build & make push 2) Updates the GHA flow
name: Release ingress-netperf container image | ||
|
||
on: | ||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We must trigger this workflow on a push event. Doing it on a pull_request
event is dangerous, as any PR would trigger a container build and can introduce incorrect or malicious code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, will change from pull_request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This PR introduces a multi-arch build/publish approach
Type of change
Description
Related Tickets & Documents
Checklist before requesting a review
Testing