Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERFSCALE-2454]: Publish multi-arch container images #34

Merged
merged 12 commits into from
Sep 21, 2023

Conversation

krishvoor
Copy link
Member

This PR introduces a multi-arch build/publish approach

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change:
krvoora # make docker-build
Building the container image
docker build --force-rm -f containers/Containerfile \
        -t quay.io/cloud-bulldozer/ingress-perf ./containers
[+] Building 1.4s (10/10) FINISHED                                                                                                                                                  
 => [internal] load .dockerignore                                                                                                                                              0.0s
 => => transferring context: 2B                                                                                                                                                0.0s
 => [internal] load build definition from Containerfile                                                                                                                        0.0s
 => => transferring dockerfile: 390B                                                                                                                                           0.0s
 => [internal] load metadata for registry.access.redhat.com/ubi8/ubi:latest                                                                                                    1.4s
 => [builder 1/2] FROM registry.access.redhat.com/ubi8/ubi:latest@sha256:2c05f0b15459fafd51807473c6d649db8cc1cfd0adf589495666d599ec79c61d                                      0.0s
 => [internal] load build context                                                                                                                                              0.0s
 => => transferring context: 30B                                                                                                                                               0.0s
 => CACHED [stage-1 2/4] RUN dnf install -y iproute procps-ng                                                                                                                  0.0s
 => CACHED [builder 2/2] RUN dnf install -y make git unzip gcc &&     git clone https://github.com/wg/wrk.git --depth=1 &&     cd wrk && make -j $(nproc)                      0.0s
 => CACHED [stage-1 3/4] COPY --from=builder /wrk/wrk /usr/bin/wrk                                                                                                             0.0s
 => CACHED [stage-1 4/4] COPY json.lua json.lua                                                                                                                                0.0s
 => exporting to image                                                                                                                                                         0.0s
 => => exporting layers                                                                                                                                                        0.0s
 => => writing image sha256:ae5da5544cec2f695649f1bc30e2c9fbb5d442554ad24c9d78c22bff92790582                                                                                   0.0s
 => => naming to quay.io/cloud-bulldozer/ingress-perf:latest                                                                                                                   0.0s
 krvoora #
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

This PR introduces multi-arch build/publish approach

Signed-off-by: Krishna Harsha Voora <[email protected]>
Makefile Outdated Show resolved Hide resolved
@krishvoor krishvoor changed the title Publish multi-arch container images [PERFSCALE-2454]: Publish multi-arch container images Sep 20, 2023
Makefile Show resolved Hide resolved
name: Release ingress-netperf container image

on:
pull_request:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must trigger this workflow on a push event. Doing it on a pull_request event is dangerous, as any PR would trigger a container build and can introduce incorrect or malicious code.

Copy link
Member Author

@krishvoor krishvoor Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, will change from pull_request

@rsevilla87 rsevilla87 self-requested a review September 21, 2023 08:19
Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rsevilla87 rsevilla87 merged commit 1186865 into cloud-bulldozer:main Sep 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants