Moves packaging image creation into Github Actions #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurkanindibay
commented
Sep 6, 2021
.github/workflows/build-package.yml
Outdated
Comment on lines
56
to
76
| - name: Clone all-citus branch for test | ||
| run: git clone -b all-citus --depth=1 https://github.com/citusdata/packaging.git packaging | ||
|
|
||
| - name: Clone tools repo for test | ||
| run: git clone -b develop_tests --depth=1 https://github.com/citusdata/tools.git packaging/tools | ||
|
|
||
| - name: Install python requirements | ||
| run: | | ||
| cd packaging | ||
| python -m pip install -r tools/packaging_automation/requirements.txt | ||
|
|
||
| - name: Test packages using built images | ||
| run: | | ||
| python -m tools.packaging_automation.citus_package \ | ||
| --gh_token "${GH_TOKEN}" \ | ||
| --packaging_docker_platform "${{ matrix.TARGET_PLATFORM }}" \ | ||
| --build_type 'release' \ | ||
| --secret_key "${PACKAGING_SECRET_KEY}" \ | ||
| --passphrase "${PACKAGING_PASSPHRASE}" \ | ||
| --output_dir "$(pwd)/packages/" \ | ||
| --input_files_dir "$(pwd)" |
There was a problem hiding this comment.
This section is performing the test. We are executing out tests on all-citus branch, i.e. performing tests on citus app.
gurkanindibay
force-pushed
the
package_ga_transition
branch
from
1f0033d
to
6a8a752
Compare
|
Needs a rebase |
gurkanindibay
force-pushed
the
package_ga_transition
branch
2 times, most recently
from
afd9191
to
6b85de7
Compare
gurkanindibay
force-pushed
the
package_ga_transition
branch
from
fd50905
to
56870d2
Compare
hanefi
reviewed
Oct 4, 2021
successfully
successfully
gurkanindibay
force-pushed
the
package_ga_transition
branch
from
1b0895b
to
69df340
Compare
hanefi
reviewed
Oct 7, 2021
hanefi
reviewed
Oct 7, 2021
* Changes update_images into update_image * Removes output validation since warnings in main branch causes nightlies to fail, so totally unrelated tasks
hanefi
approved these changes
Oct 11, 2021
Co-authored-by: Hanefi Onaldi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.