Adds packaging images release name support into citus package #177
Conversation
gurkanindibay
requested review from
onurctirtir and
hanefi
and removed request for
onurctirtir
| # def teardown_module(): | ||
| # if os.path.exists("packaging_test"): | ||
| # run("rm -r packaging_test") |
There was a problem hiding this comment.
I do not like these commented out lines
There was a problem hiding this comment.
My misatake. Uncommented lines
there are lots of place to change and it is risky and will take too much time. I need to finish conversion ASAP |
gurkanindibay
force-pushed
the
develop_tests
branch
from
5ad1eab
to
2da9eee
Compare
There was a problem hiding this comment.
I am not totally comfortable with adding yet another argument to this cli tool. The arguments are not documented well and it is not so easy to understand their purposes without digging deeper into the codebase. I have a hard time creating packages on my local machine now, and it appears that it will be even harder than before.
I hope that we can make these tools more user friendly in the future.
Packaging images creation release names are different than standard release names. Packaging images release names are seperated by comma but our general release names are seperated by '/'. Some release names are totally different as well like redhat and oracle.
In this PR, I added a map to support the ones seperated with comma
This PR is related with the one below
citusdata/packaging#745
Additionally, there was problems in pgxn and ol/8 tests.I fixed these problems in this PR as well