Add a regex style pattern to the enum-name-style #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sconwayaus
force-pushed
the
enum_name_style_regex
branch
from
e917d63
to
6f6c4a1
Compare
hzeller
reviewed
Jul 9, 2024
| "and end with '_t' or '_e'.", | ||
| "Checks that enum type names follow a naming convention defined by " | ||
| "a RE2 regular expression.\n" | ||
| "Example common regex patterns:\n" |
There was a problem hiding this comment.
Instead of repeating the same examples in various places using regexps, how about we add a little section in the lint README.md with regexp examples and just add a link here ?
(also here, the default regex, the one with the trailing _e or _t is not even mentioned)
hzeller
reviewed
Jul 9, 2024
| configuration, {{"style_regex", SetRegex(&style_regex_)}}); | ||
| if (!s.ok()) return s; | ||
|
|
||
| violation_message_ = |
There was a problem hiding this comment.
I am wondering: instead of having a validation_message_ member that we most likely never use, yet allocate and prepare should we maybe have a std::string CreateValidationMessage() {} that creates it on-the-fly if needed in the actual valdation ? It also would mean that we don't have to duplicate the code creating it in the constructor and in the Configure() method.
sconwayaus
force-pushed
the
enum_name_style_regex
branch
4 times, most recently
from
be5d5cf
to
9c50c4b
Compare
Cleaned up the violation message (remove code duplication).
sconwayaus
force-pushed
the
enum_name_style_regex
branch
from
9c50c4b
to
fa735dd
Compare
hzeller
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding regex to the enum-name-style rule, part of issue #2074