Initial support for textDocument/hover request. #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Grzegorz, I moved your the draft pull request here, so that the work is not going out-of-sync and it is easier to work on it later. |
hzeller
force-pushed
the
20240129-hover-request
branch
from
1131ef1
to
2dcf8b7
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2087 +/- ##
=======================================
Coverage 92.92% 92.92%
=======================================
Files 358 359 +1
Lines 26577 26666 +89
=======================================
+ Hits 24696 24780 +84
- Misses 1881 1886 +5 ☔ View full report in Codecov by Sentry. |
hzeller
force-pushed
the
20240129-hover-request
branch
2 times, most recently
from
1277819
to
5d14b1d
Compare
hzeller
force-pushed
the
20240129-hover-request
branch
from
5d14b1d
to
65a6aec
Compare
Rebased from PR #1922 This will implement the method, but currently it is not offered yet in the initialization to the editor; to be enabled once tests finished. The implementation requires a global symbol table, which is potentially a bit heavy. We might need to introduce the concept of a per-file symbol table for faster local lookups.
hzeller
force-pushed
the
20240129-hover-request
branch
from
65a6aec
to
2d1dd11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased from PR #1922
This will implement the method, but currently it is not offered yet in the initialization to the editor; to be enabled once tests finished.