CSR: add mconfigptr and default to zero #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RISC-V ISA requires that `mconfigptr` must be implemented.
ZenithalHourlyRate
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
In the future when https://github.com/riscv/configuration-structure is ratified, diplomacy should happily populate mconfigptr.
Actually this is required only for Priv spec 1.12 and after. Happy to see the upgrading. You could also see #3373 (comment) if you are doing more upgrading. |
|
@Mergifyio backport master |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
Priv spec 1.12 requires that `mconfigptr` must be implemented. (cherry picked from commit 113eb12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RISC-V ISA requires that
mconfigptrmust be implemented.Related issue:
Type of change: bug report
Impact: API modification
Development Phase: implementation
Release Notes