Fixed issue with oc process command and Added KIP_IMAGE parameter to configmap.yaml #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sachin-Itagi
requested review from
ibuziuk,
SDawley,
tolusha and
dkwon17
as code owners
|
Click here to review and test in web IDE: |
ibuziuk
reviewed
Feb 22, 2024
dkwon17
approved these changes
Feb 22, 2024
|
Thank you @Sachin-Itagi I believe we can merge after a new line is added at the end of |
Sachin-Itagi
force-pushed
the
addPowerParameter
branch
from
15de36c
to
e1335f8
Compare
|
Click here to review and test in web IDE: |
ibuziuk
reviewed
Feb 26, 2024
deploy/openshift/configmap.yaml
Outdated
| @@ -48,3 +49,6 @@ parameters: | |||
| value: "" | |||
| - name: AFFINITY | |||
| value: "{}" | |||
| - name: KIP_IMAGE | |||
| value: quay.io/eclipse/kubernetes-image-puller:next | |||
|
|
|||
There was a problem hiding this comment.
@Sachin-Itagi this extra line should be removed for template sanity e.g. there should be no red marks on the PR files
Sachin-Itagi
force-pushed
the
addPowerParameter
branch
from
e1335f8
to
ed64d53
Compare
|
Click here to review and test in web IDE: |
ibuziuk
reviewed
Feb 26, 2024
|
Click here to review and test in web IDE: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: https://issues.redhat.com/browse/CRW-5768
The commit modifies the apiVersion to fix the issue with the oc process command.
Also Added the KIP_IMAGE parameter that is missing in the configmap.yaml file.