Add a Development Container for a more seamless local experience #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey ! Thank you for this! I didn't have my notifications turned on so I didn't see this PR. This all makes sense to me. I will look through this today |
|
No rush at all, thanks so much for taking a look! |
|
I think this approach is great. I didn't know about dev containers so this is a great new addition. Thank you! I couldn't quite get this one working (most likely my lack of understanding) but I assume with start up instructions that I will be able to 😄 |
I'll update the README/documentation before merging. |
tarebyte
force-pushed
the
tarebyte/create-devcontainer
branch
from
ab12f40
to
d587128
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
While I was working on #305 and getting my local environment ready to go, I noticed that there were a lot of dependencies to get setup.
In order to make it easier to contribute, I thought it might be nice to have a way to run it all locally only relying on Docker and potentially VSCode if that is your editor of choice.
This Pull Request introduces a Dev Container for running the application without having to install any of the necessary dependencies on your machine. It uses the existing services defined in
docker-compose.ymlso that the services running are consistent.Here's what it looks like in VSCode.
Thanks to using Ubuntu Jammy as the base image, this can support ARM and Intel based machines.
If this is a path we'd like to move forward with, I'm happy to make changes to the README to show this as an option when getting started.
Thanks!