Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more selective in terms of clang version when using a flag in CUB compilation #25930

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Be more selective in terms of clang version when using a flag in CUB compilation #25930

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ccaf9e
Turn an unknown flag error into a warning for CUB compilation
e-kayrakli Sep 11, 2024
1a824c2
Check LLVM version before using a flag
e-kayrakli Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions runtime/src/gpu/nvidia/Makefile.share
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,13 @@ RUNTIME_CXXFLAGS += -x cuda -Wno-unknown-cuda-version \

# With cuda 11, cub headers have unused typedefs
RUNTIME_CXXFLAGS += -Wno-error=unused-local-typedef
#
# With cuda 11, cub headers have deprecated builtins
RUNTIME_CXXFLAGS += -Wno-error=deprecated-builtins -Wno-error=unknown-pragmas


ifeq ($(shell test $(CHPL_MAKE_LLVM_VERSION) -ge 15; echo "$$?"),0)
# With cuda 11, cub headers have deprecated builtins
RUNTIME_CXXFLAGS += -Wno-error=deprecated-builtins \
-Wno-error=unknown-pragmas
endif

$(RUNTIME_OBJ_DIR)/gpu-nvidia-cub.o: gpu-nvidia-cub.cc \
$(RUNTIME_OBJ_DIR_STAMP)
Expand Down