Be more selective in terms of clang version when using a flag in CUB compilation #25930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Engin Kayraklioglu <[email protected]>
|
@jabraham17 -- are you OK with me proceeding with this "fix", or is it too lazy? :) |
|
I prefer checking for the clang version, which is what we do for all of the other |
Signed-off-by: Engin Kayraklioglu <[email protected]>
jabraham17
approved these changes
Sep 11, 2024
e-kayrakli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#25918 added
-Wno-error=deprecated-builtinswhen compiling the runtime's CUB wrappers. However, that flag is not supported in some older clangs. Specifically, we added that to enable builds with clang 18, but clang 14 doesn't have that flag. This PR adds the problematic flag only if the clang version supports it.Test: