Rename handful of BigInteger functions and deprecate get_str #22818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabraham17
changed the title
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
jabraham17
force-pushed
the
bigint-rename-bundle
branch
from
3cf2e61
to
637762d
Compare
Signed-off-by: Jade Abraham <[email protected]>
bmcdonald3
approved these changes
Jul 31, 2023
Comment on lines
+519
to
+521
| // private method | ||
| @chpldoc.nodoc | ||
| proc getStr(base: int = 10): string { |
There was a problem hiding this comment.
Should we make this a private proc?
There was a problem hiding this comment.
That unfortunately requires it no longer being a method
modules/standard/BigInteger.chpl
Outdated
Comment on lines
523
to
525
| if compiledForSingleLocale() { | ||
| var tmpvar = chpl_gmp_mpz_get_str(base_, this.mpz); | ||
|
|
||
| try! { | ||
| ret = string.createAdoptingBuffer(tmpvar); | ||
| } | ||
|
|
||
| } else if this.localeId == chpl_nodeID { | ||
| if compiledForSingleLocale() || this.localeId == chpl_nodeID { |
There was a problem hiding this comment.
I think the compiledForSingleLocale() is a param, so that is why these were separated out into different branches. It's difficult to say if that is important, but that's why this was here originally. Now, in single locale configurations, we will have the branch and construction of the locale object since we can't fold that out, which can cause some overhead.
There was a problem hiding this comment.
I did test compiling this in a single locale configuration and it does not generate the extra check (looking at AST for 'codegen' pass). It is short enough code that I can also just put it back
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
3 tasks
jabraham17
added a commit
that referenced
this pull request
Jan 11, 2024
Removes almost all of the remaining BigInteger deprecations This PR removes the deprecations from the following PRs I authored - #22775 - #22888/#22774 - #22818 - #22794 - #22788 - #22121 I also removed the remaining deprecations done by Yash Raj - #18855 - #18827 I moved one test out of the deprecated/BigInteger directory, `bigint_getlimbs.chpl`, since its not a deprecation test and actually checks functionality. Testing - [x] paratest without comm - [x] paratest with comm - [x] built docs and checked them [Reviewed by @ShreyasKhandekar]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
scan0/scan1tofindNext0/findNext1and update its documentationpopcounttopopCountand update its documentationiortoorand update its argument names and documentationrootrem/sqrtremtorootRem/sqrtRemand update its argument names and documentationaddmul/submultoaddMul/subMuland update its argument names and documentationget_strin favor of casting to astringor usingwriteThisscan0andscan1New tests
test/deprecated/BigInteger/scan01.chpltest/deprecated/BigInteger/ior.chpltest/deprecated/BigInteger/popcount.chpltest/deprecated/BigInteger/rootSqrtRem.chpltest/deprecated/BigInteger/addSubMul.chpltest/deprecated/BigInteger/deprecateGet_str.chpltest/library/standard/BigInteger/getStr.chpltest/deprecated/BigInteger/deprecateScanArg.chplTesting
[Reviewed by @bmcdonald3]
closes #17737
closes #19389
implements remaining topics from #17724, closes #17724
closes cray/chapel-private#5097