Rename BigInteger functions to camelCase and unstablize number theory functions #22788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
jabraham17
force-pushed
the
bigint-unstable-bundle
branch
from
459a75a
to
f49e2f2
Compare
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
bmcdonald3
approved these changes
Jul 20, 2023
modules/standard/BigInteger.chpl
Outdated
| :return: the Jacobi symbol | ||
| :rtype: ``int`` | ||
| */ | ||
| @unstable("jacobi is unstable and may move in the future") |
There was a problem hiding this comment.
Is all that unstable means is that something may move in the future? I'm not sure we know for sure what might happen to any of these unstable methods, we just reserve the right to do whatever we want with them, so I think the wording "may move" sounds odd to me. Something like "may change" or "may be removed" or something makes more sense to me. What do you think?
There was a problem hiding this comment.
I agree and I think I prefer "may change" since we reserve the right to do whatever we want with them
Signed-off-by: Jade Abraham <[email protected]>
3 tasks
jabraham17
added a commit
that referenced
this pull request
Jan 11, 2024
Removes almost all of the remaining BigInteger deprecations This PR removes the deprecations from the following PRs I authored - #22775 - #22888/#22774 - #22818 - #22794 - #22788 - #22121 I also removed the remaining deprecations done by Yash Raj - #18855 - #18827 I moved one test out of the deprecated/BigInteger directory, `bigint_getlimbs.chpl`, since its not a deprecation test and actually checks functionality. Testing - [x] paratest without comm - [x] paratest with comm - [x] built docs and checked them [Reviewed by @ShreyasKhandekar]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a number of renaming of functions in the BigInteger module to match the Chapel naming style. Also marks several functions as unstable that may move in the future.
Summary of changes
hamdist(a)tohammingDistance(x), marked as unstablenextprime(result, a)tonextPrime(result, x), marked as unstablelucnum/lucnum2tolucNum/lucNum2, marked as unstablejacobi/legendre/kroneckeras unstablegcd/lcm/fac/bin/fib/fib2/probablyPrimeas unstablegcdextandprobab_prime_pNew tests
test/deprecated/BigInteger/deprecateHamDist.chpltest/deprecated/BigInteger/deprecateNumberTheory.chpltest/unstable/BigInteger/unstableHammingDistance.chpltest/unstable/BigInteger/unstableNumberTheory.chpltest/deprecated/BigInteger/deprecateGcdext.chpltest/deprecated/BigInteger/deprecateProbabPrimeP.chplTesting
[Reviewed by @bmcdonald3]
closes #17733
partially implements decisions from #17724
marks functions in #17697 as unstable
closes cray/chapel-private#5098