Rename bigint's setbit, tstbit, combit, and clrbit methods #22775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
bmcdonald3
approved these changes
Jul 19, 2023
3 tasks
jabraham17
added a commit
that referenced
this pull request
Jan 11, 2024
Removes almost all of the remaining BigInteger deprecations This PR removes the deprecations from the following PRs I authored - #22775 - #22888/#22774 - #22818 - #22794 - #22788 - #22121 I also removed the remaining deprecations done by Yash Raj - #18855 - #18827 I moved one test out of the deprecated/BigInteger directory, `bigint_getlimbs.chpl`, since its not a deprecation test and actually checks functionality. Testing - [x] paratest without comm - [x] paratest with comm - [x] built docs and checked them [Reviewed by @ShreyasKhandekar]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames both the procedure name and the argument name to
bigint's *bit methods (#17735 and #22008)Summary of changes
setbit(bit_index: integral)tosetBit(idx: integral)clrbit(bit_index: integral)toclearBit(idx: integral)tstbit(bit_index: integral)togetBit(idx: integral)combit(bit_index: integral)totoggleBit(idx: integral)New tests
test/deprecated/BigInteger/deprecateBitFunctions.chplTesting
[Reviewed by @bmcdonald3]
closes #17735
closes #22008
closes cray/chapel-private#5095