Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] celocli viem migration: network commands #387

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Transport instead of HttpTransport for typing

90b6a8d
Select commit
Loading
Failed to load commit list.
Draft

[WIP] celocli viem migration: network commands #387

Transport instead of HttpTransport for typing
90b6a8d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 18, 2024 in 1s

56.70% (-10.52%) compared to 6bba5e3

View this Pull Request on Codecov

56.70% (-10.52%) compared to 6bba5e3

Details

Codecov Report

Attention: Patch coverage is 25.55066% with 338 lines in your changes missing coverage. Please review.

Project coverage is 56.70%. Comparing base (6bba5e3) to head (90b6a8d).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
packages/cli/src/commands/network/parameters.ts 5.44% 139 Missing ⚠️
packages/cli/src/viem.ts 18.57% 57 Missing ⚠️
packages/cli/src/packages-to-be/fee-currency.ts 9.75% 37 Missing ⚠️
packages/cli/src/commands/network/contracts.ts 17.85% 23 Missing ⚠️
packages/cli/src/commands/network/info.ts 24.00% 19 Missing ⚠️
packages/cli/src/utils/network-config.ts 50.00% 15 Missing ⚠️
packages/cli/src/packages-to-be/epochs.ts 17.64% 14 Missing ⚠️
...ackages/cli/src/packages-to-be/address-resolver.ts 23.07% 10 Missing ⚠️
packages/cli/src/packages-to-be/l2-resolver.ts 16.66% 10 Missing ⚠️
packages/cli/src/utils/cli.ts 0.00% 7 Missing ⚠️
... and 2 more

❗ There is a different number of reports uploaded between BASE (6bba5e3) and HEAD (90b6a8d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6bba5e3) HEAD (90b6a8d)
6 5
Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #387       +/-   ##
===========================================
- Coverage   67.22%   56.70%   -10.52%     
===========================================
  Files         291      300        +9     
  Lines       10972    11383      +411     
  Branches     1565     1585       +20     
===========================================
- Hits         7376     6455      -921     
- Misses       3455     4854     +1399     
+ Partials      141       74       -67

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov