Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] celocli viem migration: network commands #387

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

shazarre
Copy link
Contributor

@shazarre shazarre commented Oct 8, 2024

Description

A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?

Other changes

Describe any minor or "drive-by" changes here.

Tested

An explanation of how the changes were tested or an explanation as to why they don't need to be.

Related issues

  • Fixes #[issue number here]

Backwards compatibility

Brief explanation of why these changes are/are not backwards compatible.

Documentation

The set of community facing docs that have been added/modified because of this change


PR-Codex overview

This PR introduces the viem package to the cli and refactors several components to enhance functionality and structure, particularly around fee currency management and network parameters.

Detailed summary

  • Added viem package to package.json.
  • Created ViemCommand class for command handling.
  • Implemented ViemFeeCurrencyProvider for fee currency management.
  • Refactored Parameters and Info commands to use ViemCommand.
  • Introduced new utility functions for epoch calculations.
  • Enhanced error handling in network configuration fetching.
  • Updated various test files to support new structures and functionalities.

The following files were skipped due to too many changes: packages/cli/src/commands/network/parameters.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 8, 2024

⚠️ No Changeset found

Latest commit: 90b6a8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 25.55066% with 338 lines in your changes missing coverage. Please review.

Project coverage is 56.70%. Comparing base (6bba5e3) to head (90b6a8d).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
packages/cli/src/commands/network/parameters.ts 5.44% 139 Missing ⚠️
packages/cli/src/viem.ts 18.57% 57 Missing ⚠️
packages/cli/src/packages-to-be/fee-currency.ts 9.75% 37 Missing ⚠️
packages/cli/src/commands/network/contracts.ts 17.85% 23 Missing ⚠️
packages/cli/src/commands/network/info.ts 24.00% 19 Missing ⚠️
packages/cli/src/utils/network-config.ts 50.00% 15 Missing ⚠️
packages/cli/src/packages-to-be/epochs.ts 17.64% 14 Missing ⚠️
...ackages/cli/src/packages-to-be/address-resolver.ts 23.07% 10 Missing ⚠️
packages/cli/src/packages-to-be/l2-resolver.ts 16.66% 10 Missing ⚠️
packages/cli/src/utils/cli.ts 0.00% 7 Missing ⚠️
... and 2 more

❗ There is a different number of reports uploaded between BASE (6bba5e3) and HEAD (90b6a8d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6bba5e3) HEAD (90b6a8d)
6 5
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #387       +/-   ##
===========================================
- Coverage   67.22%   56.70%   -10.52%     
===========================================
  Files         291      300        +9     
  Lines       10972    11383      +411     
  Branches     1565     1585       +20     
===========================================
- Hits         7376     6455      -921     
- Misses       3455     4854     +1399     
+ Partials      141       74       -67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolasbrugneaux nicolasbrugneaux linked an issue Oct 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow dual rpc client based commands
2 participants