Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade OCLIF #25

Closed
wants to merge 49 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
2bd47ac
11 errors left
aaronmgdr Dec 19, 2023
ec9650f
cli builds, tests silently exit
aaronmgdr Dec 20, 2023
501f8d4
add dev cmd for cli
aaronmgdr Dec 21, 2023
34cd77d
must force exit for these tests
aaronmgdr Dec 21, 2023
179245f
add yarn cache to the install cache
aaronmgdr Dec 21, 2023
47d57ef
yarn cache files should be in other cache
aaronmgdr Dec 21, 2023
699ea95
exclusions last?
aaronmgdr Dec 21, 2023
06d89e1
wrong level krongk
aaronmgdr Dec 21, 2023
15f4e66
a bit verbose but not terrible
aaronmgdr Dec 21, 2023
2760c22
todo once
aaronmgdr Dec 21, 2023
4d1ce3c
--cwd does not really work on yarn berry
aaronmgdr Dec 21, 2023
3591198
order imports and get lint running (not passing)
aaronmgdr Dec 21, 2023
4fb7ce9
style
aaronmgdr Dec 21, 2023
6b01dc1
missing explicit dep
aaronmgdr Dec 21, 2023
38b978a
should fix install
aaronmgdr Dec 22, 2023
465c203
upgrade all oclif related packages to latest
aaronmgdr Jan 3, 2024
e0b4f9e
use nico runner
aaronmgdr Jan 3, 2024
545a662
fix tests not running by disabling ts-node integration with oclif for…
aaronmgdr Jan 4, 2024
747fd39
tried and true
aaronmgdr Jan 4, 2024
a8ce72b
use setup node instead of container
aaronmgdr Dec 22, 2023
8be634d
cant set cache yarn yet
aaronmgdr Dec 22, 2023
944cacb
use yarn
aaronmgdr Dec 22, 2023
3fb0e4a
node yarn then configure
aaronmgdr Dec 22, 2023
1303c8b
ok it needs lock file so checkout first
aaronmgdr Dec 22, 2023
3da3af1
sync yarn
aaronmgdr Dec 22, 2023
48b8e22
must set the shell
aaronmgdr Dec 22, 2023
0d06d33
checkout then sync
aaronmgdr Dec 22, 2023
8b09639
FIX LOCATION
aaronmgdr Dec 22, 2023
fc44f33
use same path as social connect
aaronmgdr Dec 22, 2023
5338e43
it worked the commit before this. so hopefully this just removes supe…
aaronmgdr Dec 22, 2023
ffa76c4
did it fix it? no but these are help to have
aaronmgdr Dec 22, 2023
bcd1c99
we actually do need 18.17 for the repo
aaronmgdr Dec 22, 2023
2b1cb8d
add back this fox
aaronmgdr Jan 4, 2024
5dcd5fe
remove grandamento from cli
aaronmgdr Jan 4, 2024
7c14df9
fix repo suffix
aaronmgdr Jan 5, 2024
adc5c7d
fix oclif docs regneration
aaronmgdr Jan 8, 2024
790b1a7
Merge branch 'oclif' into fix-ci-caching
aaronmgdr Jan 8, 2024
6e30a4a
run on every pr
aaronmgdr Jan 8, 2024
8b66653
it will be free
aaronmgdr Jan 8, 2024
8fe1653
safer
aaronmgdr Jan 8, 2024
93a4171
remove whitespace?
aaronmgdr Jan 9, 2024
170cfb1
lets go
aaronmgdr Jan 9, 2024
d39dd94
dont pretty
aaronmgdr Jan 9, 2024
618fe6f
todo is not true
aaronmgdr Jan 9, 2024
a776591
tslint->eslint (#35)
nicolasbrugneaux Jan 10, 2024
8fabbe7
upgrade to yarn 4
aaronmgdr Jan 10, 2024
fe2fa8a
dont think we need this log
aaronmgdr Jan 10, 2024
5d614cb
Fix ci caching (#26)
aaronmgdr Jan 11, 2024
5977d3f
Merge branch 'aaronmgdr/yarn4' into oclif
aaronmgdr Jan 11, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 5 additions & 0 deletions .changeset/tough-gorillas-invent.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@celo/celocli': major
---

Remove Grandamento from CLI
236 changes: 236 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,236 @@
/*
👋 Hi! This file was autogenerated by tslint-to-eslint-config.
https://github.com/typescript-eslint/tslint-to-eslint-config

It represents the closest reasonable ESLint configuration to this
project's original TSLint configuration.

We recommend eventually switching this configuration to extend from
the recommended rulesets in typescript-eslint.
https://github.com/typescript-eslint/tslint-to-eslint-config/blob/master/docs/FAQs.md

Happy linting! 💖
*/
module.exports = {
env: {
es6: true,
node: true,
},
extends: ['prettier'],
parser: '@typescript-eslint/parser',
parserOptions: {
project: './eslint.tsconfig.json',
sourceType: 'module',
},
plugins: ['eslint-plugin-unicorn', 'eslint-plugin-import', '@typescript-eslint'],
root: true,
rules: {
'@typescript-eslint/adjacent-overload-signatures': 'error',
'@typescript-eslint/array-type': [
'error',
{
default: 'array',
},
],
'@typescript-eslint/ban-types': [
'error',
{
types: {
Object: {
message: 'Avoid using the `Object` type. Did you mean `object`?',
},
Function: {
message:
'Avoid using the `Function` type. Prefer a specific function type, like `() => void`.',
},
Boolean: {
message: 'Avoid using the `Boolean` type. Did you mean `boolean`?',
},
Number: {
message: 'Avoid using the `Number` type. Did you mean `number`?',
},
String: {
message: 'Avoid using the `String` type. Did you mean `string`?',
},
Symbol: {
message: 'Avoid using the `Symbol` type. Did you mean `symbol`?',
},
},
},
],
'@typescript-eslint/consistent-type-assertions': 'off',
'@typescript-eslint/consistent-type-definitions': 'off',
'@typescript-eslint/dot-notation': 'error',
'@typescript-eslint/explicit-function-return-type': 'off',
'@typescript-eslint/explicit-member-accessibility': [
'off',
{
accessibility: 'explicit',
},
],
'@typescript-eslint/explicit-module-boundary-types': 'off',
'@typescript-eslint/indent': 'off',
'@typescript-eslint/member-delimiter-style': [
'off',
{
multiline: {
delimiter: 'none',
requireLast: true,
},
singleline: {
delimiter: 'semi',
requireLast: false,
},
},
],
'@typescript-eslint/naming-convention': [
'error',
{
selector: 'variable',
format: null,
leadingUnderscore: 'allow',
trailingUnderscore: 'forbid',
},
],
'@typescript-eslint/no-empty-function': 'error',
'@typescript-eslint/no-empty-interface': 'error',
'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/no-floating-promises': 'error',
'@typescript-eslint/no-misused-new': 'error',
'@typescript-eslint/no-namespace': 'error',
'@typescript-eslint/no-parameter-properties': 'off',
'@typescript-eslint/no-shadow': [
'error',
{
hoist: 'all',
},
],
'@typescript-eslint/no-this-alias': 'error',
'@typescript-eslint/no-unused-expressions': 'error',
'@typescript-eslint/no-use-before-define': 'off',
'@typescript-eslint/no-var-requires': 'off',
'@typescript-eslint/prefer-for-of': 'error',
'@typescript-eslint/prefer-function-type': 'error',
'@typescript-eslint/prefer-namespace-keyword': 'error',
'@typescript-eslint/quotes': 'off',
'@typescript-eslint/semi': ['off', null],
'@typescript-eslint/triple-slash-reference': [
'error',
{
path: 'always',
types: 'prefer-import',
lib: 'always',
},
],
'@typescript-eslint/type-annotation-spacing': 'off',
'@typescript-eslint/typedef': 'off',
'@typescript-eslint/unified-signatures': 'error',
'arrow-parens': ['off', 'always'],
'brace-style': ['off', 'off'],
'comma-dangle': 'off',
complexity: 'off',
'constructor-super': 'error',
curly: 'off',
'dot-notation': 'off',
'eol-last': 'off',
eqeqeq: ['error', 'smart'],
'guard-for-in': 'error',
'id-denylist': 'error',
'id-match': 'error',
'import/no-extraneous-dependencies': [
'error',
{
devDependencies: false,
},
],
'import/no-internal-modules': 'off',
indent: 'off',
'linebreak-style': 'off',
'max-classes-per-file': ['error', 1],
'max-len': 'off',
'new-parens': 'off',
'newline-per-chained-call': 'off',
'no-bitwise': 'error',
'no-caller': 'off',
'no-cond-assign': 'error',
'no-console': 'off',
'no-constant-condition': 'error',
'no-debugger': 'error',
'no-duplicate-case': 'error',
'no-duplicate-imports': 'error',
'no-empty': 'error',
'no-empty-function': 'off',
'no-eval': 'error',
'no-extra-bind': 'error',
'no-extra-semi': 'off',
'no-fallthrough': 'off',
'no-invalid-this': 'off',
'no-irregular-whitespace': 'off',
'no-multiple-empty-lines': 'off',
'no-new-func': 'error',
'no-new-wrappers': 'error',
'no-redeclare': 'off',
'no-restricted-imports': [
'error',
{
paths: [
{
name: 'elliptic',
importNames: ['ec'],
},
],
},
],
'no-restricted-syntax': ['error', 'ForInStatement'],
'no-return-await': 'error',
'no-sequences': 'error',
'no-shadow': 'off',
'no-sparse-arrays': 'off',
'no-template-curly-in-string': 'error',
'no-throw-literal': 'error',
'no-trailing-spaces': 'off',
'no-undef-init': 'error',
'no-unsafe-finally': 'error',
'no-unused-expressions': 'off',
'no-unused-labels': 'error',
'no-use-before-define': 'off',
'no-var': 'off',
'object-shorthand': 'off',
'one-var': ['off', 'never'],
'padded-blocks': [
'off',
{
blocks: 'never',
},
{
allowSingleLineBlocks: true,
},
],
'prefer-const': 'error',
'prefer-object-spread': 'error',
'quote-props': 'off',
quotes: 'off',
radix: 'error',
semi: 'off',
'space-before-function-paren': 'off',
'space-in-parens': ['off', 'never'],
'spaced-comment': [
'error',
'always',
{
markers: ['/'],
},
],
'unicorn/prefer-ternary': 'off',
'use-isnan': 'error',
'valid-typeof': 'off',
},
overrides: [
{
files: ['src/**/*.test.ts', 'src/test-utils/*'],
rules: {
'import/no-extraneous-dependencies': 'off',
},
},
],
}
15 changes: 14 additions & 1 deletion .github/actions/sync-workspace/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,28 @@ inputs:
runs:
using: "composite"
steps:
- uses: actions/setup-node@v2
with:
node-version: '18'
- name: "enable corepack for yarn"
run : sudo corepack enable yarn
shell: bash
# must call twice because of chicken and egg problem with yarn and node
- uses: actions/setup-node@v2
with:
node-version: '18'
cache: 'yarn'
- uses: actions/cache/restore@v3
id: cache_node
env:
REBUILD_PACKAGE: ${{ inputs.rebuild-package }}
with:
path: |
./.yarn/cache
./.yarn/install-state.gz
node_modules
packages/**/node_modules
key: node-${{ runner.os }}-${{ runner.arch }}-${{ env.NODE_MODULE_CACHE_VERSION }}-${{ hashFiles('**/yarn.lock') }}
key: node-${{ runner.os }}-${{ runner.arch }}-${{ env.NODE_MODULE_CACHE_VERSION }}-${{ hashFiles('yarn.lock') }}
enableCrossOsArchive: true
fail-on-cache-miss: "!${{ fromJSON(env.REBUILD_PACKAGE) }}"
- name: Restore build artifacts cache
Expand Down
Loading