upgrade OCLIF #25
Closed
upgrade OCLIF #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix test for base, get tests running (except for cli)
🦋 Changeset detectedLatest commit: 5977d3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
no need to save maps
Merged
yarn --cwd packages/sdk/contractkit test
* use setup node instead of container * cant set cache yarn yet * use yarn * node yarn then configure * ok it needs lock file so checkout first * sync yarn * must set the shell * checkout then sync * FIX LOCATION * use same path as social connect yarn --cwd packages/sdk/contractkit test * it worked the commit before this. so hopefully this just removes superfluous things * did it fix it? no but these are help to have * we actually do need 18.17 for the repo * fix: use runner differently * wip: tslint->eslint in CLI * wip: tslint->eslint in sdk/base * wip: tslint->eslint in sdk/connect * wip: tslint->eslint in sdk/contractkit * wip: tslint->eslint in sdk/cryptographic-utils * wip: tslint->eslint in sdk/explorer * wip: tslint->eslint in sdk/governance * wip: tslint->eslint in sdk/keystores * wip: tslint->eslint in sdk/network-utils * wip: tslint->eslint in sdk/transactions-uri * wip: tslint->eslint in sdk/phone-utils * wip: tslint->eslint in sdk/utils * wip: refactor * wip: tslint->eslint in sdk/wallets/wallet-base * wip: tslint->eslint in sdk/wallets/wallet-hsm * wip: tslint->eslint in sdk/wallets/wallet-hsm-aws * wip: tslint->eslint in sdk/wallets/wallet-hsm-azure * wip: tslint->eslint in sdk/wallets/wallet-hsm-gcp * wip: tslint->eslint in sdk/wallets/wallet-ledger * wip: tslint->eslint in sdk/wallets/wallet-local * wip: tslint->eslint in sdk/wallets/wallet-remote * wip: tslint->eslint in sdk/wallets/wallet-rpc * chore: cleanup * chore: cleanup and PR feedback * chore: remove unecessary command args * fix: build * dont ignore the eslint configs * dont merge check * chore: remove releasegold * chore: remove the yarn run lint:do-not-merge * fix: celocli tests --------- Co-authored-by: Aaron <[email protected]>
|
As far as I can tell, looks good |
|
messed this up |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades Oclif (used by celocli) to its latest versions
it is based off of #21 and is the base for #26