Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dupword CI && remove repetitive words globally #1331

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion consensus/reactor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,7 @@ func timeoutWaitGroup(t *testing.T, n int, f func(int), css []*State) {
close(done)
}()

// we're running many nodes in-process, possibly in in a virtual machine,
// we're running many nodes in-process, possibly in a virtual machine,
// and spewing debug messages - making a block could take a while,
timeout := time.Second * 120

Expand Down
2 changes: 1 addition & 1 deletion consensus/state.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ type State struct {
internalMsgQueue chan msgInfo
timeoutTicker TimeoutTicker

// information about about added votes and block parts are written on this channel
// information about added votes and block parts are written on this channel
// so statistics can be computed by reactor
statsMsgQueue chan msgInfo

Expand Down
2 changes: 1 addition & 1 deletion docs/guides/go.md
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ its validation checks. The specific value of the code is meaningless to CometBFT
Non-zero codes are logged by CometBFT so applications can provide more specific
information on why the transaction was rejected.

Note that `CheckTx` does not execute the transaction, it only verifies that that the transaction could be executed. We do not know yet if the rest of the network has agreed to accept this transaction into a block.
Note that `CheckTx` does not execute the transaction, it only verifies that the transaction could be executed. We do not know yet if the rest of the network has agreed to accept this transaction into a block.


Finally, make sure to add the bytes package to the `import` stanza at the top of `app.go`:
Expand Down
2 changes: 1 addition & 1 deletion mempool/cat/pool_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ func TestTxPool_ExpiredTxs_NumBlocks(t *testing.T) {
// NOTE: When we reap txs below, we do not know if we're picking txs from the
// initial CheckTx calls or from the second round of CheckTx calls. Thus, we
// cannot guarantee that all 95 txs are remaining that should be expired and
// removed. However, we do know that that at most 95 txs can be expired and
// removed. However, we do know that at most 95 txs can be expired and
// removed.
reapedTxs = txmp.ReapMaxTxs(5)
responses = make([]*abci.ResponseDeliverTx, len(reapedTxs))
Expand Down
2 changes: 1 addition & 1 deletion mempool/v1/mempool_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,7 @@ func TestTxMempool_ExpiredTxs_NumBlocks(t *testing.T) {
// NOTE: When we reap txs below, we do not know if we're picking txs from the
// initial CheckTx calls or from the second round of CheckTx calls. Thus, we
// cannot guarantee that all 95 txs are remaining that should be expired and
// removed. However, we do know that that at most 95 txs can be expired and
// removed. However, we do know that at most 95 txs can be expired and
// removed.
reapedTxs = txmp.ReapMaxTxs(5)
responses = make([]*abci.ResponseDeliverTx, len(reapedTxs))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ then the time `b.time` in the block `b` that is signed by `c` satisfies
- `beginConsensus(k) - PRECISION <= b.time < endConsensus(k) + PRECISION + MSGDELAY`.


> [PBTS-CONSENSUS-TIME-VALID.0] is based on an analysis where the proposer is faulty (and does does not count towards `beginConsensus(k)` and `endConsensus(k)`), and we estimate the times at which correct validators receive and `accept` the `propose` message. If the proposer is correct we obtain
> [PBTS-CONSENSUS-TIME-VALID.0] is based on an analysis where the proposer is faulty (and does not count towards `beginConsensus(k)` and `endConsensus(k)`), and we estimate the times at which correct validators receive and `accept` the `propose` message. If the proposer is correct we obtain

#### **[PBTS-CONSENSUS-LIVE-VALID-CORR-PROP.0]**

Expand Down
2 changes: 1 addition & 1 deletion state/execution.go
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ func updateState(
if err != nil {
return state, fmt.Errorf("error changing validator set: %v", err)
}
// Change results from this height but only applies to the next next height.
// Change results from this height but only applies to the next height.
lastHeightValsChanged = header.Height + 1 + 1
}

Expand Down
2 changes: 1 addition & 1 deletion state/state_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ func TestValidatorSimpleSaveLoad(t *testing.T) {
assert.Nil(err, "expected no err at height 2")
assert.Equal(v.Hash(), state.NextValidators.Hash(), "expected validator hashes to match")

// Increment height, save; should be able to load for next & next next height.
// Increment height, save; should be able to load for next & next height.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one was intentional

Suggested change
// Increment height, save; should be able to load for next & next height.
// Increment height, save; should be able to load for next & one after next height.

state.LastBlockHeight++
nextHeight := state.LastBlockHeight + 1
err = statestore.Save(state)
Expand Down
2 changes: 1 addition & 1 deletion test/maverick/consensus/state.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ type State struct {
// to avoid extra requests to HSM
privValidatorPubKey crypto.PubKey

// information about about added votes and block parts are written on this channel
// information about added votes and block parts are written on this channel
// so statistics can be computed by reactor
statsMsgQueue chan msgInfo

Expand Down
2 changes: 1 addition & 1 deletion types/event_bus.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func (b *EventBus) Subscribe(
}

// This method can be used for a local consensus explorer and synchronous
// testing. Do not use for for public facing / untrusted subscriptions!
// testing. Do not use for public facing / untrusted subscriptions!
func (b *EventBus) SubscribeUnbuffered(
ctx context.Context,
subscriber string,
Expand Down
Loading