Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dupword CI && remove repetitive words globally #1331

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

goofylfg
Copy link

@goofylfg goofylfg commented May 2, 2024

Description

use https://github.com/Abirdcfly/dupword to check duplicate words && check it manually to avoid false positve.

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use
    unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@goofylfg goofylfg requested a review from a team as a code owner May 2, 2024 16:44
@goofylfg goofylfg requested review from ramin and cmwaters and removed request for a team May 2, 2024 16:44
@evan-forbes
Copy link
Member

thanks for this @goofylfg, all changes to comet specific logic should be pushed upstream to https://github.com/cometbft/cometbft so that all forks (including this one) can benefit 🙂

also, in general I think adding CI to fix this issue permanently instead of having one off fixes every now and again

thanks!

@goofylfg
Copy link
Author

goofylfg commented May 6, 2024

thanks for this @goofylfg, all changes to comet specific logic should be pushed upstream to https://github.com/cometbft/cometbft so that all forks (including this one) can benefit 🙂

also, in general I think adding CI to fix this issue permanently instead of having one off fixes every now and again

thanks!

agree!,but have tow points want to discuss:

  1. some of repetitive words is not in upstream repo, maybe we can revert cometbft related file,
  2. then add CI tools to check duplicate word in other repo
    wanna hear your advices~ @evan-forbes

@goofylfg goofylfg changed the title chore: remove repetitive words globally chore: add dupword CI && remove repetitive words globally May 9, 2024
@goofylfg
Copy link
Author

goofylfg commented May 9, 2024

similar to celestiaorg/celestia-node#3360
I will add golanglint dupword CI && then add some //nolint:dupword, but first I will fix cometbft repo

@@ -257,7 +257,7 @@ func TestValidatorSimpleSaveLoad(t *testing.T) {
assert.Nil(err, "expected no err at height 2")
assert.Equal(v.Hash(), state.NextValidators.Hash(), "expected validator hashes to match")

// Increment height, save; should be able to load for next & next next height.
// Increment height, save; should be able to load for next & next height.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one was intentional

Suggested change
// Increment height, save; should be able to load for next & next height.
// Increment height, save; should be able to load for next & one after next height.

@rootulp rootulp enabled auto-merge (squash) September 5, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants