Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge SkyCoord support to Master #80

Merged
merged 28 commits into from
Apr 22, 2024
Merged

Merge SkyCoord support to Master #80

merged 28 commits into from
Apr 22, 2024

Commits on Apr 17, 2024

  1. ✨ Implement SkyCoord support for js side

    @Xen0Xys
    Xen0Xys committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    bc50a28 View commit details
    Browse the repository at this point in the history

  2. ✨ Implement SkyCoord support for python side

    @Xen0Xys
    Xen0Xys committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    3490795 View commit details
    Browse the repository at this point in the history

  3. 🐛 Fix target support for jslink using shared_target traitlets

    @Xen0Xys
    Xen0Xys committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    8fb0a58 View commit details
    Browse the repository at this point in the history

  4. 📝 Update example 6 to fix target jslink behavior

    @Xen0Xys
    Xen0Xys committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c9cbc40 View commit details
    Browse the repository at this point in the history

  5. 🐛 Fix multi-instances flickering

    @Xen0Xys
    Xen0Xys committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c229db9 View commit details
    Browse the repository at this point in the history

  6. 🐛 Fix useless target when used in constructor

    @Xen0Xys
    Xen0Xys committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    9be2c71 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. ✨ Implement coordinate string parsing using new coordinate_parser fun… 

    …ction
    @Xen0Xys
    Xen0Xys committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    5680fd1 View commit details
    Browse the repository at this point in the history

  2. 📝 Add minor documentation for widget.js

    @Xen0Xys
    Xen0Xys committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    066e71f View commit details
    Browse the repository at this point in the history

  3. 🚀 Add missing target getter type annotation

    @Xen0Xys
    Xen0Xys committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    8d99542 View commit details
    Browse the repository at this point in the history

  4. 🐛 Fix coordinate_parser.py splitter

    @Xen0Xys
    Xen0Xys committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    c2e0fda View commit details
    Browse the repository at this point in the history

  5. ✅ Add tests for coordinate_parser.py and aladin target getter and setter

    @Xen0Xys
    Xen0Xys committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    63f903d View commit details
    Browse the repository at this point in the history

  6. 👷 Add CI for automated python code testing

    @Xen0Xys
    Xen0Xys committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    4b8e898 View commit details
    Browse the repository at this point in the history

  7. ✅ Add more testing cases for existing tests

    @Xen0Xys
    Xen0Xys committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    02d138a View commit details
    Browse the repository at this point in the history

  8. 🐛 Fix initial target when frame is galactic

    @Xen0Xys
    Xen0Xys committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    dec02bc View commit details
    Browse the repository at this point in the history

  9. 🎨 Use a regex to detect if a string is an object name or a coordinate

    @Xen0Xys
    Xen0Xys committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    9c36e6b View commit details
    Browse the repository at this point in the history

  10. 📝 Update CHANGELOG.md

    @Xen0Xys
    Xen0Xys committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    e9ae30b View commit details
    Browse the repository at this point in the history

  11. 📝 Add _target and shared_target trait help & remove useless error in … 

    …trait getter
    @Xen0Xys
    Xen0Xys committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    a0d2a09 View commit details
    Browse the repository at this point in the history

  12. 🎨 Fix python import order

    @Xen0Xys
    Xen0Xys committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    38c6695 View commit details
    Browse the repository at this point in the history

  13. 🐛 Fix missing event unsubscribe for shared_target

    @Xen0Xys
    Xen0Xys committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    4f2f168 View commit details
    Browse the repository at this point in the history

  14. 🎨 Improve conditional structure for the target setter

    @Xen0Xys
    Xen0Xys committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    f55c2e2 View commit details
    Browse the repository at this point in the history

  15. 📝 Improve the meaning of a sentence in the changelog

    @Xen0Xys
    Xen0Xys committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    a271cb4 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. 🎨 Improve target setter conditions

    @Xen0Xys
    Xen0Xys committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    644b4c3 View commit details
    Browse the repository at this point in the history

  2. ✨ Add parsing support for coordinate string starting by J, G and B

    @Xen0Xys
    Xen0Xys committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    5c816c6 View commit details
    Browse the repository at this point in the history

  3. ✅ Improve testing for new coordinate parsing functions

    @Xen0Xys
    Xen0Xys committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    cb99a4b View commit details
    Browse the repository at this point in the history

  4. 📝 Change docstring format from sphinx to numpy

    @Xen0Xys
    Xen0Xys committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    b71946c View commit details
    Browse the repository at this point in the history

  5. 🎨 Improve conditional structure for parse_coordinate_string function

    @Xen0Xys
    Xen0Xys committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    cfc112f View commit details
    Browse the repository at this point in the history

  6. fix: type annotations union for python <3.9

    @ManonMarchand
    ManonMarchand committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    5e177dd View commit details
    Browse the repository at this point in the history

  7. docs: fix doctring style 

    did a pass of ruff's doctrings linter
    @ManonMarchand
    ManonMarchand committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    815c6bf View commit details
    Browse the repository at this point in the history