Merge SkyCoord support to Master #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Tom! Fixes: #51 For the gitignore, you can edit your local I'll have a look at the rest tomorrow 🙂 Edit: could you rebase on master? I tried to fix the codestyle workflow |
bmatthieu3
requested changes
Apr 17, 2024
There was a problem hiding this comment.
Thanks @Xen0Xys . I do have some little things to suggest. Overall it is very good :D
Xen0Xys
force-pushed
the
feature/skycoord-support
branch
from
1007818
to
3490795
Compare
Xen0Xys
force-pushed
the
feature/skycoord-support
branch
from
1af15df
to
c229db9
Compare
Xen0Xys
force-pushed
the
feature/skycoord-support
branch
from
39f98f6
to
4b8e898
Compare
Xen0Xys
force-pushed
the
feature/skycoord-support
branch
from
e531c91
to
9c36e6b
Compare
Xen0Xys
force-pushed
the
feature/skycoord-support
branch
from
4b4a753
to
e9ae30b
Compare
ManonMarchand
requested changes
Apr 18, 2024
ManonMarchand
approved these changes
Apr 18, 2024
|
Merged, thanks Tom! 🎉 |
ManonMarchand
pushed a commit
that referenced
this pull request
Apr 22, 2024
* ✨ Implement SkyCoord support for js side * ✨ Implement SkyCoord support for python side * 🐛 Fix target support for jslink using shared_target traitlets * 📝 Update example 6 to fix target jslink behavior * 🐛 Fix multi-instances flickering * 🐛 Fix useless target when used in constructor * ✨ Implement coordinate string parsing using new coordinate_parser function * 📝 Add minor documentation for widget.js * 🚀 Add missing target getter type annotation * 🐛 Fix coordinate_parser.py splitter * ✅ Add tests for coordinate_parser.py and aladin target getter and setter * 👷 Add CI for automated python code testing * ✅ Add more testing cases for existing tests * 🐛 Fix initial target when frame is galactic * 🎨 Use a regex to detect if a string is an object name or a coordinate * 📝 Update CHANGELOG.md * 📝 Add _target and shared_target trait help & remove useless error in trait getter * 🎨 Fix python import order * 🐛 Fix missing event unsubscribe for shared_target * 🎨 Improve conditional structure for the target setter * 📝 Improve the meaning of a sentence in the changelog * 🎨 Improve target setter conditions * ✨ Add parsing support for coordinate string starting by J, G and B * ✅ Improve testing for new coordinate parsing functions * 📝 Change docstring format from sphinx to numpy * 🎨 Improve conditional structure for parse_coordinate_string function * fix: type annotations union for python <3.9 * docs: fix doctring style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO