Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event Handling Infrastructure #15223

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Event Handling Infrastructure #15223

merged 1 commit into from
Jul 25, 2023

Conversation

codeNinjaDev
Copy link
Contributor

@codeNinjaDev codeNinjaDev commented Jul 5, 2023 •
edited
Loading

Basic code to manage handling of incoming events via event reader.

Jira: https://cdap.atlassian.net/browse/CDAP-20678
Interacting with event-reader-spi

The EventSubscriberManager will initialize all EventSubscribers (e.g StartProgramEventSubscriber, etc...) and start them if the event reading feature is enabled.

Each EventSubscriber (a ScheduledService) will handle a specific type of event and will initialize its respective EventReader with the DefaultEventReaderContext.

The EventReaderExtensionProvider provides the available EventReaders to the EventSubscribers.

@codeNinjaDev codeNinjaDev force-pushed the feature/cdap-20678-event-pr branch 3 times, most recently from 064e879 to eddb737 Compare July 7, 2023 23:41
@codeNinjaDev codeNinjaDev marked this pull request as ready for review July 10, 2023 21:29
@codeNinjaDev codeNinjaDev added the build Triggers github actions build label Jul 11, 2023
@codeNinjaDev codeNinjaDev force-pushed the feature/cdap-20678-event-pr branch 3 times, most recently from 8af0718 to baad386 Compare July 11, 2023 22:04
@codeNinjaDev codeNinjaDev mentioned this pull request Jul 11, 2023
Merged
@codeNinjaDev codeNinjaDev force-pushed the feature/cdap-20678-event-pr branch 3 times, most recently from 21196c9 to 0ebcd76 Compare July 12, 2023 20:55
@codeNinjaDev codeNinjaDev force-pushed the feature/cdap-20678-event-pr branch 3 times, most recently from f884aa8 to a67a367 Compare July 17, 2023 19:12
@codeNinjaDev codeNinjaDev requested a review from chtyim July 18, 2023 16:55
@codeNinjaDev codeNinjaDev force-pushed the feature/cdap-20678-event-pr branch 2 times, most recently from 9a0a50d to 2db73f2 Compare July 19, 2023 04:42
@masoud-io masoud-io added build Triggers github actions build and removed build Triggers github actions build labels Jul 20, 2023
@codeNinjaDev
Copy link
Contributor Author

Tested in sandbox (without enabling event subscribing), deploying and running a pipeline is successful

masoud-io
masoud-io reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@masoud-io masoud-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. LGTM otherwise.

cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/EventSubscriberManager.java Outdated Show resolved Hide resolved
@codeNinjaDev codeNinjaDev merged commit f3d7b36 into develop Jul 25, 2023
5 checks passed
@codeNinjaDev codeNinjaDev deleted the feature/cdap-20678-event-pr branch July 25, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masoud-io masoud-io masoud-io approved these changes

@greeshmaswaminathan greeshmaswaminathan greeshmaswaminathan approved these changes

@chtyim chtyim Awaiting requested review from chtyim

Assignees
No one assigned
Labels
build Triggers github actions build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codeNinjaDev @masoud-io @greeshmaswaminathan