-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event Handling Infrastructure #15223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeNinjaDev
commented
Jul 5, 2023
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/DefaultEventReaderContext.java
Outdated
Show resolved
Hide resolved
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
3 times, most recently
from
July 7, 2023 23:41
064e879
to
eddb737
Compare
...ic/src/main/java/io/cdap/cdap/internal/app/runtime/distributed/DistributedProgramRunner.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/EventHandler.java
Outdated
Show resolved
Hide resolved
...e-ext-dataproc/src/main/java/io/cdap/cdap/runtime/spi/provisioner/dataproc/DataprocConf.java
Outdated
Show resolved
Hide resolved
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
from
July 10, 2023 16:41
eddb737
to
df40ef4
Compare
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
from
July 10, 2023 22:24
df40ef4
to
a842b7e
Compare
masoud-io
reviewed
Jul 11, 2023
...ic/src/main/java/io/cdap/cdap/internal/app/runtime/distributed/DistributedProgramRunner.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/DefaultEventReaderContext.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/DefaultEventReaderContext.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/EventReaderHandlerManager.java
Outdated
Show resolved
Hide resolved
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
3 times, most recently
from
July 11, 2023 22:04
8af0718
to
baad386
Compare
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
3 times, most recently
from
July 12, 2023 20:55
21196c9
to
0ebcd76
Compare
masoud-io
reviewed
Jul 14, 2023
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/DefaultEventReaderContext.java
Outdated
Show resolved
Hide resolved
cdap-common/src/main/java/io/cdap/cdap/common/conf/Constants.java
Outdated
Show resolved
Hide resolved
masoud-io
reviewed
Jul 17, 2023
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/DefaultEventReaderContext.java
Show resolved
Hide resolved
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
3 times, most recently
from
July 17, 2023 19:12
f884aa8
to
a67a367
Compare
codeNinjaDev
commented
Jul 17, 2023
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/DefaultEventReaderContext.java
Outdated
Show resolved
Hide resolved
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
from
July 17, 2023 19:21
a67a367
to
b412a26
Compare
codeNinjaDev
commented
Jul 17, 2023
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/DefaultEventReaderContext.java
Show resolved
Hide resolved
...bric/src/main/java/io/cdap/cdap/internal/events/dummy/DummyEventReaderExtensionProvider.java
Outdated
Show resolved
Hide resolved
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
from
July 18, 2023 16:58
b412a26
to
88f843d
Compare
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
2 times, most recently
from
July 19, 2023 04:42
9a0a50d
to
2db73f2
Compare
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
from
July 19, 2023 18:12
2db73f2
to
eab9de6
Compare
masoud-io
added
build
Triggers github actions build
and removed
build
Triggers github actions build
labels
Jul 20, 2023
masoud-io
reviewed
Jul 20, 2023
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/EventSubscriber.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/EventSubscriberManager.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/EventSubscriberManager.java
Show resolved
Hide resolved
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
from
July 20, 2023 18:07
661e057
to
5e32be4
Compare
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/DefaultEventReaderContext.java
Show resolved
Hide resolved
cdap-common/src/main/java/io/cdap/cdap/common/conf/Constants.java
Outdated
Show resolved
Hide resolved
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
from
July 21, 2023 17:16
5e32be4
to
fc7e81d
Compare
Tested in sandbox (without enabling event subscribing), deploying and running a pipeline is successful |
masoud-io
reviewed
Jul 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment. LGTM otherwise.
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/EventSubscriberManager.java
Outdated
Show resolved
Hide resolved
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
from
July 24, 2023 21:44
6ee2dde
to
80c0a88
Compare
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/EventSubscriberManager.java
Outdated
Show resolved
Hide resolved
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
from
July 24, 2023 22:30
80c0a88
to
5846b08
Compare
greeshmaswaminathan
approved these changes
Jul 25, 2023
codeNinjaDev
commented
Jul 25, 2023
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/EventSubscriberManager.java
Show resolved
Hide resolved
masoud-io
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic code to manage handling of incoming events via event reader.
Jira: https://cdap.atlassian.net/browse/CDAP-20678
Interacting with event-reader-spi
The EventSubscriberManager will initialize all EventSubscribers (e.g StartProgramEventSubscriber, etc...) and start them if the event reading feature is enabled.
Each EventSubscriber (a ScheduledService) will handle a specific type of event and will initialize its respective EventReader with the DefaultEventReaderContext.
The EventReaderExtensionProvider provides the available EventReaders to the EventSubscribers.