-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StartProgram Event Handling #15227
Merged
Merged
StartProgram Event Handling #15227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeNinjaDev
force-pushed
the
feature/handler-extension
branch
from
July 11, 2023 16:34
a582a00
to
5277104
Compare
chtyim
reviewed
Jul 11, 2023
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventHandler.java
Outdated
Show resolved
Hide resolved
chtyim
reviewed
Jul 11, 2023
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventHandler.java
Outdated
Show resolved
Hide resolved
chtyim
reviewed
Jul 11, 2023
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventHandler.java
Outdated
Show resolved
Hide resolved
chtyim
reviewed
Jul 11, 2023
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventHandler.java
Outdated
Show resolved
Hide resolved
chtyim
reviewed
Jul 11, 2023
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventHandler.java
Outdated
Show resolved
Hide resolved
chtyim
reviewed
Jul 11, 2023
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventHandler.java
Outdated
Show resolved
Hide resolved
chtyim
reviewed
Jul 11, 2023
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventHandler.java
Outdated
Show resolved
Hide resolved
chtyim
reviewed
Jul 11, 2023
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventHandler.java
Outdated
Show resolved
Hide resolved
chtyim
reviewed
Jul 11, 2023
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/events/StartProgramEventHandlerTest.java
Outdated
Show resolved
Hide resolved
codeNinjaDev
force-pushed
the
feature/handler-extension
branch
3 times, most recently
from
July 11, 2023 18:05
002fd72
to
73db87b
Compare
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
2 times, most recently
from
July 11, 2023 20:32
fcda35c
to
adbc549
Compare
codeNinjaDev
force-pushed
the
feature/handler-extension
branch
4 times, most recently
from
July 11, 2023 22:15
7730313
to
441d837
Compare
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
from
July 11, 2023 23:15
baad386
to
d460bab
Compare
codeNinjaDev
force-pushed
the
feature/handler-extension
branch
2 times, most recently
from
July 12, 2023 20:49
8f46328
to
0e7fd72
Compare
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
from
July 12, 2023 20:55
21196c9
to
0ebcd76
Compare
codeNinjaDev
force-pushed
the
feature/handler-extension
branch
from
July 12, 2023 20:56
0e7fd72
to
e049f33
Compare
masoud-io
reviewed
Jul 17, 2023
cdap-common/src/main/java/io/cdap/cdap/common/conf/Constants.java
Outdated
Show resolved
Hide resolved
...ric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventReaderExtensionProvider.java
Outdated
Show resolved
Hide resolved
...ric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventReaderExtensionProvider.java
Outdated
Show resolved
Hide resolved
...ric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventReaderExtensionProvider.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventSubscriber.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventSubscriber.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventSubscriber.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventSubscriber.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventSubscriber.java
Outdated
Show resolved
Hide resolved
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
from
July 17, 2023 17:16
0ebcd76
to
31e5edc
Compare
codeNinjaDev
force-pushed
the
feature/handler-extension
branch
from
July 19, 2023 18:14
eb4d1ce
to
e87b961
Compare
masoud-io
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
masoud-io
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Couples of notes:
- Make sure to squash commits before merge.
- Make sure to submit after event handling infra PR.
- Make sure to get a second LGTM
codeNinjaDev
force-pushed
the
feature/handler-extension
branch
from
July 20, 2023 20:00
e87b961
to
afce0ad
Compare
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventSubscriber.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventSubscriber.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/events/StartProgramEventSubscriberTest.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/events/StartProgramEventSubscriberTest.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/events/StartProgramEventSubscriberTest.java
Outdated
Show resolved
Hide resolved
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
from
July 21, 2023 17:17
5e32be4
to
fc7e81d
Compare
codeNinjaDev
force-pushed
the
feature/handler-extension
branch
2 times, most recently
from
July 21, 2023 18:06
155900d
to
83b4d93
Compare
Tested in sandbox (without enabling event subscribing), deploying and running a pipeline is successful |
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
from
July 24, 2023 21:44
6ee2dde
to
80c0a88
Compare
...ric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventReaderExtensionProvider.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/dummy/DummyEventReader.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/events/StartProgramEventSubscriberTest.java
Outdated
Show resolved
Hide resolved
codeNinjaDev
force-pushed
the
feature/cdap-20678-event-pr
branch
from
July 24, 2023 22:30
80c0a88
to
5846b08
Compare
codeNinjaDev
force-pushed
the
feature/handler-extension
branch
from
July 24, 2023 22:55
e439468
to
490372c
Compare
codeNinjaDev
force-pushed
the
feature/handler-extension
branch
2 times, most recently
from
July 25, 2023 18:04
2b965e9
to
f780ecb
Compare
codeNinjaDev
force-pushed
the
feature/handler-extension
branch
from
July 25, 2023 18:22
f780ecb
to
1c0407e
Compare
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/EventSubscriber.java
Outdated
Show resolved
Hide resolved
codeNinjaDev
force-pushed
the
feature/handler-extension
branch
from
July 25, 2023 21:51
34593d1
to
1747f7e
Compare
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/EventSubscriber.java
Show resolved
Hide resolved
greeshmaswaminathan
approved these changes
Jul 26, 2023
codeNinjaDev
force-pushed
the
feature/handler-extension
branch
from
July 26, 2023 17:31
1747f7e
to
0ca463b
Compare
codeNinjaDev
force-pushed
the
feature/handler-extension
branch
from
July 26, 2023 20:00
0ca463b
to
10c66e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on Event Reader Subscriber infrastructure to handle StartProgramEvents:
Based on #15223