Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump SDL version #5382

Closed
wants to merge 1 commit into from

Conversation

RoyalFox2140
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 commented Sep 19, 2024

Checklist

Required

Purpose of change

Older versions of SDL have potential issues, this brings it in line 2.30.3 according to my debug.log

This does not fix any of my specific outstanding issues with the renderer. I tested.

18:23:52.918 INFO : SDL version used during compile is 2.30.0
18:23:52.918 INFO : SDL version used during linking and in runtime is 2.30.3

Describe the solution

Bump Ubuntu to 24.04 which will fetch the proper dependencies. Thanks Robbie.

You can find a working manual release of this here, but without linux you can't test the PR.
https://github.com/RoyalFox2140/Cataclysm-BN/releases

Describe alternatives you've considered

None. We don't need to support older Ubuntu as we can assist users in self compiling and they should get around to upgrading anyway.

Testing

https://github.com/RoyalFox2140/Cataclysm-BN/releases Load tested on Linux x64 Tiles and my existing saves still work. I can't find any new problems.

Additional context

@OrenAudeles @scarf005 Pings due to relevancy.

Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/cataclysmbnteam/Cataclysm-BN/actions/runs/10949945220/job/30404218596?pr=5382#step:8:27

pip install fails in requirements.sh due to newer pip version having different policy. this can be workaround using --break-system-packages flag, e.g pip install --user polib luaparser --break-system-packages

check https://stackoverflow.com/questions/75608323/how-do-i-solve-error-externally-managed-environment-every-time-i-use-pip-3 for details.

@RobbieNeko RobbieNeko mentioned this pull request Sep 19, 2024
4 tasks
@RobbieNeko
Copy link
Contributor

Superseded by #5384

@RoyalFox2140
Copy link
Collaborator Author

Thanks Robbie!

@RobbieNeko
Copy link
Contributor

No problem! ^-^

@RoyalFox2140 RoyalFox2140 deleted the Update-SDL2 branch September 22, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants