Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18 perc data file node #20

Closed
wants to merge 28 commits into from
Closed

18 perc data file node #20

wants to merge 28 commits into from

Conversation

dinodeep
Copy link
Collaborator

@dinodeep dinodeep commented Nov 7, 2023

Pull Request

Addresses Issue #18 (PERC-Data-File-Node)

Description

Mostly a structural PR for Perceptions to make code a lot cleaner and well organized

  • Removed perceptions dependency on ros2_numpy package (now using ros2_numpy_dv which is not a git submodule) (going to make a future PR where all submodules related to perceptions are no longer submodules and just have the _dv suffix)
  • Created a FileNode class for saving data to the file system as npz files so that people can test with data without the need to run ROS nodes, making testing a more seamless for perceptions specific code (still encouraging people to test their code on Dale though)
  • Created a PredictNode which provides an interface for performing predictions on ROS nodes
  • Restructured code into folders for better modularity and cleanliness
  • Created a ZEDNode that publishes raw camera data that the DataNode can synchronize and read from

Check-list

  • Integration tests pass
  • Code Documented (and Confluence documentation updated)
  • Reviewer 1 approved

@dinodeep dinodeep linked an issue Nov 7, 2023 that may be closed by this pull request
4 tasks
@GeoffTheJetson GeoffTheJetson deleted the 18-perc-data-file-node branch February 21, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PERC-Data File Node
3 participants