Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #375 (I think) #434

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Fix #375 (I think) #434

merged 1 commit into from
Jan 19, 2023

Commits on Jan 19, 2023

  1. Fix capnproto#375 (I think)

    This addresses capnproto#375; the now-deleted comment about the time gap being OK
    has been incorrect at least since we started handling `receiverAnswer`s
    specially; the test that was failing was one where a reference to an
    answer's promise filed (and transitively pcall) is handed to a method
    implementation.
    
    This patch avoids having a gap where pcall & promise are nil by:
    
    - Changing setPipelineCaller so it can be called before we release the
      lock
    - Introducing a stand-in type for the pipeline caller that we can set
      pcall to while the RecvCall is ongoing.
    
    Before fixing the bug it took many thousands or tens of thousands of
    test runs to trigger it, so while I have not been able to reproduce the
    issue after tens of thousands of runs, that alone is inconclusive -- but
    I *think* this fixes the bug. It definitely fixes something.
    zenhack committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    5ce76b8 View commit details
    Browse the repository at this point in the history